Skip to content

Clean up Processed local image links in Management api #16828

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
elit0451 merged 5 commits into from
Jul 29, 2024
Merged

Clean up Processed local image links in Management api #16828

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
2c200d7
Removed type attribute from processed local links
Migaroez Jul 15, 2024
b14e734
Removed type attribute from processed locallinks in delivery api
Migaroez Jul 15, 2024
0360ef8
Removed type attribute from expected output regarding locallink parsing
Migaroez Jul 15, 2024
8d6173e
Added type atttribute removal in deliveryapi for local image link and…
Migaroez Jul 15, 2024
95b9b7d
Merge branch 'v14/dev' into v14/feature/local-image-links
Migaroez Jul 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions src/Umbraco.Infrastructure/DeliveryApi/ApiRichTextMarkupParser.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,8 +62,16 @@ private void ReplaceLocalLinks(HtmlDocument doc, IPublishedSnapshot publishedSna
link.SetAttributeValue("data-start-item-id", route.StartItem.Id.ToString("D"));
link.Attributes["type"]?.Remove();
},
url => link.SetAttributeValue("href", url),
() => link.Attributes.Remove("href"));
url =>
{
link.SetAttributeValue("href", url);
link.Attributes["type"]?.Remove();
},
() =>
{
link.Attributes.Remove("href");
link.Attributes["type"]?.Remove();
});
}
}

Expand Down
2 changes: 1 addition & 1 deletion ...mbraco.Tests.UnitTests/Umbraco.Infrastructure/DeliveryApi/ApiRichTextMarkupParserTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@ public void Can_Parse_LocalLinks()
}

[Test]
public void Can_Parse_Legacy_LocalImages()
public void Can_Parse_Inline_LocalImages()
{
var key1 = Guid.Parse("395bdc0e8f4d4ad4af7f3a3f6265651e");
var data1 = new MockData()
Expand Down