Fix date conversion on the server-side#16841
Merged
Conversation
Contributor
Contributor
|
Resaving data type applied correct time. |
Migaroez
approved these changes
Aug 12, 2024
Zeegaan
pushed a commit
that referenced
this pull request
Aug 12, 2024
(cherry picked from commit ceddf86)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Prerequisites
If there's an existing issue for this PR then this fixes #16795 (and #16779)
Description
The
DateTimeOffsetparsing added in #16732 is the root cause of both #16795 and #16779. #16779 was fixed by a client-side change in the 14.1.1 patch, but #16795 still happens in that patch.By the looks of it, any "date without time" property value saved before 14.1 will not work in 14.1 and 14.1.1 😱
This PR fixes the problem at server level by:
DateTimeOffset>DateTimeconversion and vice versa forobjecttypes.Unit tests have been added to guard against this issue later on.
Testing this