Skip to content

Management API: Refactor element tree controllers to use start node filter service#22598

Draft
lauraneto wants to merge 1 commit intov18/devfrom
v18/improvement/refactor-element-start-node-tree-controllers
Draft

Management API: Refactor element tree controllers to use start node filter service#22598
lauraneto wants to merge 1 commit intov18/devfrom
v18/improvement/refactor-element-start-node-tree-controllers

Conversation

@lauraneto
Copy link
Copy Markdown
Contributor

@lauraneto lauraneto commented Apr 24, 2026

Summary

  • Refactors UserStartNodeFolderTreeControllerBase to delegate start node filtering to IUserStartNodeTreeFilterService, matching the pattern established for document and media trees in Management API: Reduce user start node tree filtering code duplication #22486
  • Introduces IElementStartNodeTreeFilterService and ElementStartNodeTreeFilterService to handle element-specific start node resolution (both Element and ElementContainer object types)
  • Adds a virtual TreeObjectTypes property to UserStartNodeTreeFilterService so subclasses can supply multiple object types without changing the base class contract
  • Updates all element tree controllers (Root, Children, Ancestors, Siblings) to use the new service via DI

This is the v18 counterpart to #22486 (v17), covering the element tree controllers that were introduced in v18. The original v18 PR was #22016 (closed).

Testing

Open the backoffice and navigate to the element tree. Verify that root, children, ancestors, and sibling tree operations behave the same as before for both admin users (root access, no filtering) and restricted users (with element start nodes configured). Confirm that folder nodes and element nodes both appear correctly in the tree.

Move user start node filtering logic from UserStartNodeFolderTreeControllerBase
and ElementTreeControllerBase into a dedicated ElementStartNodeTreeFilterService,
matching the pattern established for document and media trees in PR #22486.

Add a virtual TreeObjectTypes property to UserStartNodeTreeFilterService so
element trees can query both Element and ElementContainer object types.
@github-actions
Copy link
Copy Markdown

Hi there @lauraneto, thank you for this contribution! 👍

While we wait for one of the Core Collaborators team to have a look at your work, we wanted to let you know about that we have a checklist for some of the things we will consider during review:

  • It's clear what problem this is solving, there's a connected issue or a description of what the changes do and how to test them
  • The automated tests all pass (see "Checks" tab on this PR)
  • The level of security for this contribution is the same or improved
  • The level of performance for this contribution is the same or improved
  • Avoids creating breaking changes; note that behavioral changes might also be perceived as breaking
  • If this is a new feature, Umbraco HQ provided guidance on the implementation beforehand
  • 💡 The contribution looks original and the contributor is presumably allowed to share it

Don't worry if you got something wrong. We like to think of a pull request as the start of a conversation, we're happy to provide guidance on improving your contribution.

If you realize that you might want to make some changes then you can do that by adding new commits to the branch you created for this work and pushing new commits. They should then automatically show up as updates to this pull request.

Thanks, from your friendly Umbraco GitHub bot 🤖 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant