Conversation
…late fixes, and skill improvements Comprehensive E2E testing for the create-mcp-server CLI, bug fixes found during manual testing, a new container mode for wrapping MCP servers, and template/skill improvements from real-world usage feedback. CLI Bug Fixes - McpOAuthComposer.cs: Try-catch resilience so Umbraco starts before DB is ready (unattended install) - setup-instance.ts: Write connection string to appsettings.local.json, unattended install config to appsettings.Development.json, patch Program.cs to load appsettings.local.json - Template TS errors: Fix createToolResult signature, jest.fn typing in server-config.test.ts - collections.ts cleanup: removeExamples() now cleans up collections.ts imports E2E Tests CLI E2E (19 deterministic steps, cli-e2e.test.ts): - Scaffold → init (Forms + SQL Server) → start Umbraco → API user creation → token verification → swagger discovery → .discover.json → generate client → TypeScript compile → unit tests → integration test against real Umbraco → real API calls → hosted worker Container Mode E2E (5 steps): - Scaffold → remove API tools → compile → build → worker starts Skill E2E (3 steps, skill-e2e.test.ts, opt-in via RUN_SKILL_TESTS=true): - /build-tools creates Language collection that compiles - /build-tools-tests creates integration tests - Integration tests pass against real Umbraco Infrastructure: Random SQL Server database per run, KEEP_E2E_ASSETS=true for preserving project between runs, test:e2e:revert for resetting skill output, test:e2e:cleanup for teardown. Container Mode New init prompt choice: "Container mode — wrap other MCP servers via chaining, no direct API tools" - removeApiTools() strips orval, generated client, example tools while keeping chaining infrastructure - Tool mode question comes after Umbraco instance setup (instance always needed for OAuth) Template Improvements - Self-signed certs in Jest: Override globalThis.fetch with undici's fetch (Node 22's built-in fetch ignores NODE_TLS_REJECT_UNAUTHORIZED in Jest VM sandbox) - MSW conditional: Gate setupMswServer() behind USE_MOCK_API=true (was blocking real API calls in integration tests) - .gitignore: Added to template (demo-site/, .env, appsettings.local.json, .discover.json) Skill Improvements - build-tools: Compile after EACH tool file, not batch - build-tools-tests: Complete working builder example with delete/cleanup, anti-pattern warning for result.content[0].text (must use createSnapshotResult), initializeUmbracoFetch in setup.ts template, read-only collection guidance - count-tools: Replace glob npm package with Node 22 built-in fs.globSync - Plugin install: Correct commands in discover output (/plugin marketplace add + /plugin install)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…late fixes, and skill improvements
Comprehensive E2E testing for the create-mcp-server CLI, bug fixes found during manual testing, a new container mode for wrapping MCP servers, and template/skill improvements from real-world usage feedback.
CLI Bug Fixes
E2E Tests
CLI E2E (19 deterministic steps, cli-e2e.test.ts):
Container Mode E2E (5 steps):
Skill E2E (3 steps, skill-e2e.test.ts, opt-in via RUN_SKILL_TESTS=true):
Infrastructure: Random SQL Server database per run, KEEP_E2E_ASSETS=true for preserving project between runs, test:e2e:revert for resetting skill output, test:e2e:cleanup for teardown.
Container Mode
New init prompt choice: "Container mode — wrap other MCP servers via chaining, no direct API tools"
Template Improvements
Skill Improvements