Relax path sanitizer, add elicitation support, fix eval compatibility#27
Merged
Relax path sanitizer, add elicitation support, fix eval compatibility#27
Conversation
The eval runner now passes an onElicitation callback to the Claude
Agent SDK's query() function. This enables eval testing of tools
that use MCP elicitation (server.elicitInput()).
- Add onElicitation to AgentTestOptions (per-test override)
- Add defaultOnElicitation to EvalConfig (global default)
- Default: auto-accept with { confirm: true } if neither is set
- Bump @anthropic-ai/claude-agent-sdk to ^0.2.39 (adds OnElicitation type)
🤖 Generated with [Claude Code](https://claude.com/claude-code)
Co-Authored-By: Claude <noreply@anthropic.com>
ProxiedTool.originalTool now includes outputSchema from the chained server's listTools response. proxiedToolsToDefinitions passes it through so consumers can register proxied tools with structured content. Note: hosted MCP's registerChainedTools cannot pass raw JSON Schema outputSchema to registerTool (expects Zod). Documented as limitation. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
…support MCP SDK <1.28.0 strips structuredContent from tool call responses, causing chained tools to return text content only. Bumping to 1.28+ ensures structuredContent is preserved on the wire when tools define outputSchema. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
…bility - Narrow rejectPathTraversal to only block ../ ..\\ and Windows drive paths, allowing /-prefixed paths that Umbraco uses as identifiers for stylesheets, scripts, and partial views - Add Symbol.asyncDispose polyfill for Jest VM context (fixes Claude Agent SDK "Object not disposable" error in eval tests) - Add @anthropic-ai/claude-agent-sdk dependency to tests/cli - Update McpOAuthComposer client ID to umbraco-back-office-hosted-mcp Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
The SDK changed registerTool's callback signature — when InputArgs is undefined, ToolCallback<undefined> expects (extra) => Result (1 arg), but ToolDefinition.handler has (args, extra) => Result. Cast handler at the call site since inputSchema is always passed alongside it. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
rejectPathTraversalno longer blocks/-prefixed paths, which Umbraco uses as identifiers for stylesheets, scripts, and partial views. Still blocks../,..\, UNC paths, and Windows drive paths.onElicitationcallback in eval runner,outputSchemaonProxiedTooltype@modelcontextprotocol/sdkto ^1.28.0 forstructuredContentsupportSymbol.asyncDisposefor Jest VM context (fixes "Object not disposable" error with upgraded Claude Agent SDK)umbraco-back-office-hosted-mcpTest plan
🤖 Generated with Claude Code