Skip to content
This repository was archived by the owner on Dec 13, 2021. It is now read-only.

Add filtering to docType selection overlay#46

Merged
leekelleher merged 2 commits intoumco:developfrom
dnwhte:feature-filter-doctypes
Feb 5, 2019
Merged

Add filtering to docType selection overlay#46
leekelleher merged 2 commits intoumco:developfrom
dnwhte:feature-filter-doctypes

Conversation

@dnwhte
Copy link
Copy Markdown

@dnwhte dnwhte commented Jan 25, 2019

What it says on the tin.

@leekelleher
Copy link
Copy Markdown
Contributor

Oooo, thank you @dnwhte! I'll review this in the coming days.

@leekelleher leekelleher self-requested a review January 28, 2019 11:56
@leekelleher
Copy link
Copy Markdown
Contributor

I've take a look at this, I'm liking it. Although I'm tempted to make it as a configurable option in the prevalue fields. As it'll be great for when there's a long list of Doc Types, but if there are a few, I don't think it's necessary. I'll take a look to see how this might work.

@leekelleher
Copy link
Copy Markdown
Contributor

leekelleher commented Jan 28, 2019

@dnwhte I've updated this PR with the config option, (in the Data Type settings).

However it will require a small tweak to Stacked Content to make it work, since the prevalues are only passed to the property-editor, not the overlay directly. So SC will need to pass in the enableFilter value.


Here's the commit on Stacked Content: umco/umbraco-stacked-content@24edb59

leekelleher added a commit to umco/umbraco-stacked-content that referenced this pull request Jan 28, 2019
@leekelleher
Copy link
Copy Markdown
Contributor

@mattbrailsford Did you want to take a look at this? I'm happy for it to be merged in.

@leekelleher
Copy link
Copy Markdown
Contributor

@mattbrailsford Here's a screengrab of the filter...

ic-doctype-filter

@leekelleher leekelleher merged commit 40cb701 into umco:develop Feb 5, 2019
@leekelleher
Copy link
Copy Markdown
Contributor

Merged in, thanks @dnwhte! 🎉

@dnwhte dnwhte deleted the feature-filter-doctypes branch July 25, 2019 23:26
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Development

Successfully merging this pull request may close these issues.

2 participants