Skip to content

Conversation

@albaintor
Copy link
Contributor

Stop command is available but not the feature is not enabled

Copy link
Contributor

@zehnm zehnm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change has no effect if config/profiles/default.json is available. The features are loaded from the matching device profile, with default as fallback. As long as there's a profile with "manufacturer": "default", the _default_profile variable is reassigned to that profile (profiles.py:199).
Only if the profiles cannot be loaded or are changed, this predefined list is used. This should only happen when running the integration externally.

Where did you encounter the missing stop feature?

@albaintor
Copy link
Contributor Author

albaintor commented Jul 10, 2024

This change has no effect if config/profiles/default.json is available. The features are loaded from the matching device profile, with default as fallback. As long as there's a profile with "manufacturer": "default", the _default_profile variable is reassigned to that profile (profiles.py:199). Only if the profiles cannot be loaded or are changed, this predefined list is used. This should only happen when running the integration externally.

Where did you encounter the missing stop feature?

Indeed, there is something I don't understand : the issue has been reported on discord here https://discord.com/channels/553671366411288576/1163576491775361095/1259078664323203124

On my device (nvidia shield, I use internal integration) the stop command is missing too. This fix is not enough, I added the stop command into the nvidia profile. It should probably be added in google chromecast profile (also missing) ?

image

@albaintor albaintor requested a review from zehnm July 10, 2024 06:59
Copy link
Contributor

@zehnm zehnm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding the stop feature to the profile makes sense.
I'll test with Chromecast and add it there as well if the command is working.

@zehnm zehnm merged commit 1d1eadb into unfoldedcircle:main Jul 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants