Skip to content

Added Help and Defaults#2

Merged
daltonmenezes merged 5 commits into
uni-linux:masterfrom
jfgordon2:master
Apr 15, 2020
Merged

Added Help and Defaults#2
daltonmenezes merged 5 commits into
uni-linux:masterfrom
jfgordon2:master

Conversation

@jfgordon2

Copy link
Copy Markdown
Contributor
  • Add uni --help to provide available use options in CLI
  • Assume default recipe owner if not provided (since there's currently only one, anyway) for ease of typing -- allows typing just uni bake yarn-install for example

image

Added help to see options in CLI, and set default recipe owner (since there's currently only one, anyway)

@daltonmenezes daltonmenezes left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Jamesits , great additions. I made a change request, also can you update the docs?

Comment thread uni Outdated
Removed hardcoded recipes, moved into wget to grab current README on recipe's github
@jfgordon2
jfgordon2 requested a review from daltonmenezes April 14, 2020 23:57

@daltonmenezes daltonmenezes left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Jamesits It will print the following result
img

What if you achieve the following result? It looks cleaner and easier to read / understand. What do you think about it?
img

Update to further trim README
@jfgordon2

Copy link
Copy Markdown
Contributor Author

Updated -- just as an FYI, the more text transformation we apply on the README, the more likely it may break if styling on the markdown is significantly updated, but I've tried to keep it as flexible as possible.

image

@jfgordon2
jfgordon2 requested a review from daltonmenezes April 15, 2020 01:06
Spellcheck
@daltonmenezes

Copy link
Copy Markdown
Member

@jfgordon2 Looks great for me, thanks. I'll keep the same style in that readme. Just a few fixes more. uni bake how yarn-installis not affected by the default recipe feature. Can you please fix it? After this, just update this and this with your modifications and I can merge your pull request.

Updated Docs and also bugfix to include default in bake how
@jfgordon2

Copy link
Copy Markdown
Contributor Author

@daltonmenezes updated for your review

@daltonmenezes
daltonmenezes merged commit e4f40c1 into uni-linux:master Apr 15, 2020
@daltonmenezes

Copy link
Copy Markdown
Member

@jfgordon2 Well done. Thank you so much. :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants