Skip to content

ICU-23055 Fix broken links in docs #3279

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 4, 2025
Merged

ICU-23055 Fix broken links in docs #3279

merged 1 commit into from
Jun 4, 2025

Conversation

sh-cho
Copy link

@sh-cho sh-cho commented Nov 21, 2024

Fixed broken links in the docs. Also fixed links like https://unicode-org.github.io/icu/userguide/strings/index because it makes sidebar closed and erase current position.

Checklist

  • Required: Issue filed: https://unicode-org.atlassian.net/browse/ICU-23055
  • Required: The PR title must be prefixed with a JIRA Issue number. Example: "ICU-1234 Fix xyz"
  • Required: The PR description must include the link to the Jira Issue, for example by completing the URL in the first checklist item
  • Required: Each commit message must be prefixed with a JIRA Issue number. Example: "ICU-1234 Fix xyz"
  • Issue accepted (done by Technical Committee after discussion)
  • Tests included, if applicable
  • API docs and/or User Guide docs changed or added, if applicable

@CLAassistant
Copy link

CLAassistant commented Nov 21, 2024

CLA assistant check
All committers have signed the CLA.

sven-oly
sven-oly previously approved these changes Feb 19, 2025
Copy link
Contributor

@sven-oly sven-oly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I apologize for being so slow to reply to this. Thank you!

@echeran echeran changed the title ICU-22921 Fix broken links in docs ICU-23055 Fix broken links in docs May 29, 2025
@echeran
Copy link
Contributor

echeran commented May 29, 2025

@sh-cho Thank you so much for this PR! It needs one simple update from you and then it will be ready to merge. In the CI checks area of the PR, the single-commit job name is hyperlinked. If you click that, it goes to a page. Check the checkbox and click the squash button. That's it. (The commit message title field should be prepopulated with something that begins with "ICU-23055 ", such as "ICU-23055 Fix broken links in docs", and that prefix is important.)

I already updated a lot of the ticket administrative information and preformed the merge conflict resolution due to upstream changes, so all of that should be ready to go.

@jira-pull-request-webhook
Copy link

Hooray! The files in the branch are the same across the force-push. 😃

~ Your Friendly Jira-GitHub PR Checker Bot

@echeran echeran merged commit 18be9a0 into unicode-org:main Jun 4, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants