Skip to content

ICU-23152 Unicode helper APIs #3539

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 22, 2025
Merged

ICU-23152 Unicode helper APIs #3539

merged 1 commit into from
Jul 22, 2025

Conversation

markusicu
Copy link
Member

@markusicu markusicu commented Jul 1, 2025 •
edited
Loading

Checklist

  • Required: Issue filed: ICU-23152
  • Required: The PR title must be prefixed with a JIRA Issue number. Example: "ICU-1234 Fix xyz"
  • Required: Each commit message must be prefixed with a JIRA Issue number. Example: "ICU-1234 Fix xyz"
  • Issue accepted (done by Technical Committee after discussion)
  • Tests included, if applicable
  • API docs and/or User Guide docs changed or added, if applicable

ALLOW_MANY_COMMITS=true

@markusicu markusicu changed the title Unicode helper APIs ICU-23152 Unicode helper APIs Jul 1, 2025
@jira-pull-request-webhook

This comment was marked as outdated.

Sign in to view
@jira-pull-request-webhook

This comment was marked as outdated.

Sign in to view
@jira-pull-request-webhook

This comment was marked as outdated.

Sign in to view
@jira-pull-request-webhook

This comment was marked as outdated.

Sign in to view
mihnita
mihnita previously approved these changes Jul 2, 2025
View reviewed changes
Copy link
Contributor

@mihnita mihnita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple of nitpicks.

@jira-pull-request-webhook

This comment was marked as outdated.

Sign in to view
@jira-pull-request-webhook

This comment was marked as outdated.

Sign in to view
@markusicu markusicu requested review from eggrobin and richgillam July 18, 2025 18:15
@markusicu markusicu marked this pull request as ready for review July 18, 2025 18:15
@markusicu
Copy link
Member Author

I think this is ready. Over to my reviewers 🎉

@mihnita
Copy link
Contributor

mihnita commented Jul 18, 2025

Thank you.

I've reviewed everything C/C++/Java
And not just the look of the public APIs, but I tried to follow all the bit fiddling :-)
I didn't find anything wrong (but it does not mean that it's perfect ;-)

M.

@markusicu
Copy link
Member Author

Thanks Mihai for reviewing this thoroughly!
@richgillam @eggrobin if I don't hear from you by 14:00 PT I plan to squash and then merge this PR.

@jira-pull-request-webhook
Copy link

Hooray! The files in the branch are the same across the force-push. 😃

~ Your Friendly Jira-GitHub PR Checker Bot

@markusicu markusicu merged commit ce3f11a into unicode-org:main Jul 22, 2025
165 of 166 checks passed
@markusicu markusicu deleted the unihelpers branch July 22, 2025 00:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mihnita mihnita mihnita approved these changes

@eggrobin eggrobin Awaiting requested review from eggrobin

@richgillam richgillam Awaiting requested review from richgillam

Assignees

@eggrobin eggrobin

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@markusicu @mihnita @eggrobin