Shareability #81
Open
Shareability #81
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e video id in the URL
…in order to match the error catch in videoplayer. when errors occur in either personal videos or random videos, the videoplayer must be able to catch both cases. naming the arrays the same will allow it to do that.
…it as an array of hashes to the index page
…string for unique identification of dream
…cript to manipulate.
…uffering time on my machine.
unknownbreaker
force-pushed
the
shareability
branch
from
bd65616 to
76b3594
Compare
|
Adding Michael Angelo, since you were trying to combine all the branches earlier and you and Steph know the setTimeouts super deep. I modified two of the setTimeouts by increasing them both by 4 seconds. I needed the extra buffering time because it kept erroring out on all the videos otherwise. No videos would play for me but would instead go into that endless recursion of destroying the player and running videomaker again and again. You had also mentioned in your IM that you couldn't get passed the OAuth. When you updated the .env in my branch, did you kill the rails server and restart it? |
| count += 1 | ||
| } else if (array.length > 0) { | ||
| setTimeout(function() {videoList(array[0]), array.shift()}, 10000); | ||
| setTimeout(function() {videoList(array[0]), array.shift()}, 14000); |
There was a problem hiding this comment.
This should remain 10000.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Behavior:
Oddities:
Notes (please read):
Since this is not an AJAX call, the returned hash/JSON from the database could not be directly handled by the JavaScript code. Instead, it had to be passed through an instance variable, that loads it on the DOM itself. Then a jQuery call captures that data and saves it into a variable for further manipulation by the JavaScript logic.