feat(combobox): add usePortal prop to ComboboxList.vue#1337
Closed
kaspernowak wants to merge 1 commit into
Closed
Conversation
Collaborator
|
Sorry for late late response, and thanks for the PR
|
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
#1336
❓ Type of change
📚 Description
This PR adds a
usePortalprop to ComboboxList.vue in the New York V4 registry.Why:
Currently,
ComboboxListalways wraps the dropdown content in aComboboxPortal, preventing parent components from controlling whether the dropdown is rendered inline or teleported. This causes major usability issues on mobile devices, where teleporting the dropdown often results in poor UX due to the on-screen keyboard and viewport constraints.What:
usePortalprop (default:true) to ComboboxList.vue.usePortalisfalse, the dropdown content is rendered inline, solving the mobile usability problem.usePortalistrue, the previous teleport behavior is preserved.I would like to note, that the changes made to the stepper component json files, came from running
pnpm build:registryon a fresh clone of the dev branch.Also, I have not updated the documentation, as I found that it is currently in a weird place as I mentioned in #1316, and needs to be refactor before I would dare contributing to it.
Resolves #1336
📸 Screenshots (if appropriate)
N/A
📝 Checklist