Skip to content

feat(enhancement/v4): proper 404 handling, custom error page on docs #1469

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sadeghbarati merged 2 commits into from
Oct 12, 2025
Merged

feat(enhancement/v4): proper 404 handling, custom error page on docs #1469

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6c07f9e
chore: create proper 404 error when docs page entry is not found
ace-of-aces Oct 11, 2025
28364c8
feat(enhancement): add custom error page
ace-of-aces Oct 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 2 additions & 9 deletions apps/v4/app.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,20 +10,13 @@ const useIdFunction = () => useId()
</script>

<template>
<Body
class="text-foreground group/body overscroll-none font-sans antialiased [--footer-height:calc(var(--spacing)*14)] [--header-height:calc(var(--spacing)*14)] xl:[--footer-height:calc(var(--spacing)*24)]"
:class="[
activeTheme ? `theme-${activeTheme}` : '',
isScaled ? 'theme-scaled' : '',
isLayoutFull ? 'layout-full' : 'layout-fixed',
]"
>
<SiteBody>
<ConfigProvider>
<NuxtLayout :use-id="useIdFunction">
<NuxtPage />
</NuxtLayout>
</ConfigProvider>

<Toaster :theme="colorMode.preference as any || 'system'" position="top-center" />
</Body>
</SiteBody>
</template>
18 changes: 18 additions & 0 deletions apps/v4/components/SiteBody.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
<script setup lang="ts">
const { config, isLayoutFull } = useConfig()
const activeTheme = computed(() => config.value.activeTheme)
const isScaled = computed(() => !!activeTheme.value?.endsWith('-scaled'))
</script>

<template>
<Body
class="text-foreground group/body overscroll-none font-sans antialiased [--footer-height:calc(var(--spacing)*14)] [--header-height:calc(var(--spacing)*14)] xl:[--footer-height:calc(var(--spacing)*24)]"
:class="[
activeTheme ? `theme-${activeTheme}` : '',
isScaled ? 'theme-scaled' : '',
isLayoutFull ? 'layout-full' : 'layout-fixed',
]"
>
<slot />
</Body>
</template>
31 changes: 31 additions & 0 deletions apps/v4/error.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,31 @@
<script setup lang="ts">
import type { NuxtError } from '#app'
import { ConfigProvider } from 'reka-ui'
import Button from './registry/new-york-v4/ui/button/Button.vue'

defineProps<{
error: NuxtError
}>()

const useIdFunction = () => useId()
</script>

<template>
<SiteBody>
<ConfigProvider>
<NuxtLayout name="default" :use-id="useIdFunction">
<div class="flex flex-col items-center justify-center gap-6 text-center min-h-[80vh]">
<PageHeader>
<PageHeaderHeading>{{ error.statusCode }}</PageHeaderHeading>
<PageHeaderDescription>{{ error.message }}</PageHeaderDescription>
<Button as-child class="w-fit mt-6">
<NuxtLink to="/">
Go back home
</NuxtLink>
</Button>
</PageHeader>
</div>
</NuxtLayout>
</ConfigProvider>
</SiteBody>
</template>
14 changes: 4 additions & 10 deletions apps/v4/pages/docs/[...slug].vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,10 @@ const { data: page } = await useAsyncData(route.path, () => {
return queryCollection('content').path(route.path).first()
})

if (!page.value) {
throw createError({ statusCode: 404, statusMessage: 'Page not found' })
}

const { data: neighbours } = await useAsyncData(`surround-${route.path}`, () => {
return queryCollectionItemSurroundings('content', route.path)
})
Expand Down Expand Up @@ -120,14 +124,4 @@ const { data: neighbours } = await useAsyncData(`surround-${route.path}`, () =>
</div>
</div>
</template>

<template v-else>
<div class="empty-page">
<h1>Page Not Found</h1>
<p>Oops! The content you're looking for doesn't exist.</p>
<NuxtLink to="/">
Go back home
</NuxtLink>
</div>
</template>
</template>