Skip to content

fix(registry): use correct selector data-highlight for command-item highlight#1786

Open
aervxa wants to merge 1 commit intounovue:devfrom
aervxa:fix-command-highlight
Open

fix(registry): use correct selector data-highlight for command-item highlight#1786
aervxa wants to merge 1 commit intounovue:devfrom
aervxa:fix-command-highlight

Conversation

@aervxa
Copy link
Copy Markdown

@aervxa aervxa commented Apr 21, 2026

❓ Type of change

  • 📖 Documentation (updates to the documentation, readme or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

only applicable to the new styles, the original new-york styles already use data-highlighted

the component command-item checks for the wrong data attribute, data-selected, but reka-ui emits data-highlighted as specified here

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

Not applicable/necessary

Summary by CodeRabbit

Release Notes

  • Style
    • Updated command menu component styling to use "highlighted" state indicators instead of "selected" states for visual feedback when interacting with command items and shortcuts across all design themes. Functionality and component behavior remain unchanged.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 21, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: c8c9c8f2-15aa-4265-afef-35682cee2308

📥 Commits

Reviewing files that changed from the base of the PR and between 5a94ad2 and 55cde03.

📒 Files selected for processing (24)
  • apps/v4/public/r/styles/reka-luma/command.json
  • apps/v4/public/r/styles/reka-lyra/command.json
  • apps/v4/public/r/styles/reka-maia/command.json
  • apps/v4/public/r/styles/reka-mira/command.json
  • apps/v4/public/r/styles/reka-nova/command.json
  • apps/v4/public/r/styles/reka-vega/command.json
  • apps/v4/registry/styles/style-luma.css
  • apps/v4/registry/styles/style-lyra.css
  • apps/v4/registry/styles/style-maia.css
  • apps/v4/registry/styles/style-mira.css
  • apps/v4/registry/styles/style-nova.css
  • apps/v4/registry/styles/style-vega.css
  • apps/v4/styles/reka-luma/ui/command/CommandItem.vue
  • apps/v4/styles/reka-luma/ui/command/CommandShortcut.vue
  • apps/v4/styles/reka-lyra/ui/command/CommandItem.vue
  • apps/v4/styles/reka-lyra/ui/command/CommandShortcut.vue
  • apps/v4/styles/reka-maia/ui/command/CommandItem.vue
  • apps/v4/styles/reka-maia/ui/command/CommandShortcut.vue
  • apps/v4/styles/reka-mira/ui/command/CommandItem.vue
  • apps/v4/styles/reka-mira/ui/command/CommandShortcut.vue
  • apps/v4/styles/reka-nova/ui/command/CommandItem.vue
  • apps/v4/styles/reka-nova/ui/command/CommandShortcut.vue
  • apps/v4/styles/reka-vega/ui/command/CommandItem.vue
  • apps/v4/styles/reka-vega/ui/command/CommandShortcut.vue

📝 Walkthrough

Walkthrough

The PR updates Command UI components across all five style variants (Luma, Lyra, Maia, Mira, Nova, Vega) to use data-highlighted state selectors instead of data-selected for visual styling in both Vue component templates and CSS stylesheets.

Changes

Cohort / File(s) Summary
Command Item Components
apps/v4/styles/reka-*/ui/command/CommandItem.vue, apps/v4/public/r/styles/reka-*/command.json
Updated :class selectors from data-selected:* to data-highlighted:* for background, text, and nested SVG text color styling across all five style variants (Luma, Lyra, Maia, Mira, Nova, Vega).
Command Shortcut Components
apps/v4/styles/reka-*/ui/command/CommandShortcut.vue, apps/v4/public/r/styles/reka-*/command.json
Changed conditional CSS group selector from group-data-selected/command-item:text-foreground to group-data-highlighted/command-item:text-foreground across all five style variants.
Registry CSS Styles
apps/v4/registry/styles/style-*.css
Updated Tailwind @apply selectors in .cn-command-item and .cn-command-shortcut classes from data-selected to data-highlighted state references across all six style sheets (Luma, Lyra, Maia, Mira, Nova, Vega).

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

Poem

🐰 With whiskers twitching and joy so bright,
States are highlighted, not selected—what a sight!
From Luma to Vega, the UI commands dance,
New data attributes give menus their chance!

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The PR title 'fix(registry): use correct selector data-highlight for command-item highlight' accurately describes the core change: replacing data-selected selectors with data-highlighted across command component styling files. The title is specific, clear, and directly reflects the main objective of the changeset.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant