Skip to content

vite-plugin-solid 2.11.2 and onwards (up to 2.11.6) seems to break unplugin-icons/vite with "solid" icon compiler #399

@bjesuiter

Description

@bjesuiter

Describe the bug

Hello Folks,

maybe I'm wrong here, I did also make an issue in the vite-plugin-solid repo.
solidjs/vite-plugin-solid#206

Anyways, this is the issue:

When Installing vite-plugin-solid 2.11.2, I get the following issue with unplugin-icons/vite:

Image

For some reason, this unplugin tag is not compiled for solid but for react:

<FolderFullIcon class="mb-[3px] inline text-slate-600" />

This issue is not present in vite-plugin-solid 2.11.1:

Image

What regression could that be?

Note on the minimal reproducible

I tried to replicate it here:
https://stackblitz.com/edit/solidjs-templates-zhovufey?file=src%2FApp.tsx,package.json,tsconfig.json

But for some reason, it'seems to work there. I've put the original repo where my problem occured into the "minimal reproducable", since I'ts the most minimal repo i have currently.
I'll look into this later to probably find a more minimal example.

Reproduction

https://github.com/bjesuiter/chrome-session-quicksave-manifest-v3

System Info

System:
    OS: macOS 15.3.2
    CPU: (14) arm64 Apple M3 Max
    Memory: 195.63 MB / 36.00 GB
    Shell: 5.9 - /bin/zsh
  Binaries:
    Node: 22.14.0 - ~/.local/state/fnm_multishells/92372_1743283083620/bin/node
    Yarn: 1.22.22 - ~/.bun/bin/yarn
    npm: 10.9.2 - ~/.local/state/fnm_multishells/92372_1743283083620/bin/npm
    pnpm: 9.0.6 - ~/.bun/bin/pnpm
    bun: 1.2.5 - ~/.bun/bin/bun
  Browsers:
    Chrome: 134.0.6998.166
    Safari: 18.3.1

Used Package Manager

bun

Validations

  • Follow our Code of Conduct
  • Read the Contributing Guide.
  • Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
  • Check that this is a concrete bug. For Q&A, please open a GitHub Discussion instead.
  • The provided reproduction is a minimal reproducible of the bug.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions