Skip to content

Add editorial order by value#204

Merged
Magellol merged 1 commit into
masterfrom
add-editorial
May 10, 2023
Merged

Add editorial order by value#204
Magellol merged 1 commit into
masterfrom
add-editorial

Conversation

@Magellol
Copy link
Copy Markdown
Member

@Magellol Magellol commented May 10, 2023

It is now supported.

@Magellol Magellol marked this pull request as ready for review May 10, 2023 14:25
@Magellol Magellol requested a review from a team as a code owner May 10, 2023 14:25
@Magellol Magellol requested a review from astlouisf May 10, 2023 14:25
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 10, 2023

size-limit report 📦

Path Size
dist/unsplash-js.cjs.production.min.js 4.21 KB (0%)
dist/unsplash-js.esm.js 4.22 KB (0%)

Copy link
Copy Markdown
Contributor

@astlouisf astlouisf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I still don't understand why it is a sort order and not a filter but 🤷‍♂️

  • filter: editorial sort by: latest
  • filter: editorial sort by: relevant

seems both more useful that sort by: editorial

@Magellol
Copy link
Copy Markdown
Member Author

I think an argument can be made for both. A little bit more details here https://linear.app/unsplash/issue/UNS-1917/%F0%9F%97%82-improve-search-filters#comment-0b9035fb but I'm not sure this matters too much in this case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants