This repository was archived by the owner on Aug 14, 2019. It is now read-only.
added initial image support to udon parser #1085
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
The first issue can be fixed by replacing with I'll commit, squash and push later today. |
jfranklin9000
force-pushed
the
udon-image
branch
from
e4a0524 to
283ca79
Compare
jfranklin9000
force-pushed
the
udon-image
branch
from
283ca79 to
36d98bc
Compare
Contributor
Author
|
I've pushed the no-alt-text fix. |
|
This is great! Having to use Sail for images in otherwise-Udon files was annoying. |
Merged
joemfb
added a commit
that referenced
this pull request
Mar 13, 2019
* master: (38 commits) bumped ames protocol number landscape 3f83c798bd61b7e6cef5c4e2f7c7f3ac89d4ec09 removed hard calls on json blobs Support eth_getBlockByNumber Ethereum RPC call added initial image support to udon parser (#1085) Tiebout - Apple Push Notification Server App (#1084) Implement +from-unix for turning timestamps into @da Add support to `lens-command` for pill output and optimized base64 encoding. (#1068) Point to the correct topics when decoding Azimuth events Add trailing newlines Use unit to disambiguate poll timer state Lightly re-order ++watcher core, add comments Implement ++peek so the app can by scried Remove debug pokes Implement %eth-watcher, an app for tracking Ethereum events add control flow to |verb Be accurate in incoming/hoon-side structures also More accurately represent Ethereum RPC filter topics also pin validate-x to now pin to local time because using local desk ...
BernardoDeLaPlaz
pushed a commit
to BernardoDeLaPlaz/arvo
that referenced
this pull request
Mar 22, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch implements
markdown to udon.The
alt-textis displayed ifimage-urldoesn't exist.One small issue is
produces analt=""tag.This is fine if
image-urlexists, butshows the broken image icon in Firefox (desired), while Chrome
shows nothing (arguably correct). I'd like to see the broken
image icon and will look into not adding the
alttag in thiscase.
Another issue concerns
.This affects link markdown too:
[some-content](link-url "title-text").https://urbit.org/docs/learn/arvo/arvo-internals/udon/doesnot mention title text markdown so it doesn't exist in udon.
However, the parser will consume it and produce
<a href="link-url "title-text"">some-content</a>instead of using a
titletag. I will look into proper title texthandling for links and images.
I don't think either of these issues should prevent a pull.