This repository was archived by the owner on Aug 14, 2019. It is now read-only.
add +bake #1148
Merged
add +bake #1148
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Sounds good to me! Feel like we could bake the name a bit more though.
… On Apr 16, 2019, at 1:33 PM, Philip Monk ***@***.***> wrote:
As described in #1145, wet gates are often more tricky to use than dry gates. +bake takes a wet gate and a type and monomorphizes the wet gate into a dry gate with the given argument type.
You can view, comment on, or merge this pull request online at:
#1148
Commit Summary
add +bake
File Changes
M sys/hoon.hoon (7)
Patch Links:
https://github.com/urbit/arvo/pull/1148.patch
https://github.com/urbit/arvo/pull/1148.diff
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub, or mute the thread.
|
sys/hoon.hoon
Outdated
| -- | ||
| a | ||
| :: | ||
| :: +bake Convert wet gate to dry gate by specifying argument mold |
There was a problem hiding this comment.
+bake: convert wet gate to dry gate by specifying argument mold
Contributor
Author
There was a problem hiding this comment.
ah, I just used a 1-nearest neighbor algorithm for determining comment style.
belisarius222
approved these changes
Apr 16, 2019
belisarius222
left a comment
belisarius222
left a comment
There was a problem hiding this comment.
LGTM other than comment format
philipcmonk
force-pushed
the
philip/bake
branch
from
8838471 to
2e52c13
Compare
philipcmonk
force-pushed
the
philip/bake
branch
from
2e52c13 to
1be2c1f
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As described in #1145, wet gates are often more tricky to use than dry gates.
+baketakes a wet gate and a type and monomorphizes the wet gate into a dry gate with the given argument type.