Add tag target to guard against version mismatch#23
Merged
Conversation
Contributor
|
What's the release process after this? I am assuming:
|
brackendawson
approved these changes
Nov 4, 2022
Member
Author
|
@brackendawson That's what I have in mind, at least for now 😅 Roughly analogous to what's described here. |
brackendawson
added a commit
that referenced
this pull request
Feb 9, 2024
Based on urfave/cli and this conversation: #23 (comment)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Given the peculiarity of the "release artifact" containing the version1, it has historically been easy to create a tag that does not match what is reported by the tool, such as version
v1.7.0reportingv1.6.0. Thismaketarget is meant to be used in place of runninggit tag ...directly to help guard against this in the future, e.g.:(edit) Question! Should the embedded version be modified post-tag so that it indicates unreleased? Something like
TAG_VERSION+ patch bump +-prelike how some tools do it?Footnotes
it isn't peculiar for the release artifact to contain the version, really, but to "release" the
gimmescript unaltered from source is an intended use case, so here we are ↩