Skip to content

The Go VERSION file now also contains a timestamp #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
brackendawson merged 5 commits into from
Nov 27, 2024
Merged

The Go VERSION file now also contains a timestamp #27

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
4df45b9
The VERSION file from Go now also includes a date on line 2
brackendawson Nov 21, 2024
71c0f6e
Fix new shellcheck findings
brackendawson Nov 21, 2024
3ff1bef
Update sample versions
brackendawson Nov 21, 2024
83c875e
Workflows require Go
brackendawson Nov 21, 2024
7aa787b
prepare v1.8.1
brackendawson Nov 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .github/workflows/main.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,9 @@ jobs:
restore-keys: |
${{ runner.os }}-prebuild-
- run: ./gimme module | grep ^export | tee -a "${GITHUB_ENV}"
- uses: actions/setup-go@v5

@tianon tianon Nov 27, 2024

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This feels moderately ironic, given the purpose of this repository/tool 😂

@brackendawson brackendawson Nov 27, 2024

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It amused me too. 😆

with:
go-version: 'stable'
- run: make gimme-generate
- uses: actions/upload-artifact@v3
with:
Expand Down Expand Up @@ -84,6 +87,9 @@ jobs:
restore-keys: |
${{ runner.os }}-${{ matrix.env.target }}-${{ matrix.env.version }}-test-
${{ runner.os }}-${{ matrix.env.target }}-
- uses: actions/setup-go@v5
with:
go-version: 'stable'
- uses: actions/download-artifact@v3
with:
name: gimme-generate-${{ runner.os }}
Expand Down
10 changes: 5 additions & 5 deletions .testdata/sample-versions.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,8 @@

#

1.19.3
1.18.8
1.17.13
1.16.15
1.15.15
1.23.3
1.22.9
1.21.13
1.20.14
1.19.13
8 changes: 4 additions & 4 deletions gimme
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ set -o pipefail

[[ ${GIMME_DEBUG} ]] && set -x

readonly GIMME_VERSION="v1.8.0"
readonly GIMME_VERSION="v1.8.1"
readonly GIMME_COPYRIGHT="Copyright (c) 2022 gimme contributors"
readonly GIMME_LICENSE_URL="https://raw.githubusercontent.com/urfave/gimme/${GIMME_VERSION}/LICENSE"
export GIMME_VERSION
Expand Down Expand Up @@ -523,13 +523,13 @@ _list_versions() {
local current_version
current_version="$(go env GOROOT 2>/dev/null)"
current_version="${current_version##*/go}"
current_version="${current_version%%.${GIMME_OS}.*}"
current_version="${current_version%%."${GIMME_OS}".*}"

# 1.1 1.10 1.2 is bad; zsh has `setopt numeric_glob_sort` but bash
# doesn't appear to have anything like that.
for d in "${GIMME_VERSION_PREFIX}/go"*".${GIMME_OS}."*; do
local cleaned="${d##*/go}"
cleaned="${cleaned%%.${GIMME_OS}.*}"
cleaned="${cleaned%%."${GIMME_OS}".*}"
echo "${cleaned}"
done | _version_sort | while read -r cleaned; do
echo -en "${cleaned}"
Expand Down Expand Up @@ -652,7 +652,7 @@ _get_curr_stable() {
_update_stable "${stable}"
fi

cat "${stable}"
head -n 1 "${stable}"
}

_get_old_stable() {
Expand Down