Skip to content

Conversation

ascjones
Copy link
Collaborator

A suggestion to remove some duplication

@codecov-io
Copy link

codecov-io commented Aug 16, 2019

Codecov Report

Merging #172 into add-ext-call-followup will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@                  Coverage Diff                   @@
##           add-ext-call-followup     #172   +/-   ##
======================================================
  Coverage                  79.21%   79.21%           
======================================================
  Files                         67       67           
  Lines                       5009     5009           
======================================================
  Hits                        3968     3968           
  Misses                      1041     1041

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fbd27ac...4e29e98. Read the comment docs.

Copy link
Collaborator

@Robbepop Robbepop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Robbepop Robbepop merged commit ec5edf8 into add-ext-call-followup Aug 16, 2019
Robbepop added a commit that referenced this pull request Aug 16, 2019
* [core] ext_call PR followup and refinements

* [core] add call_invoke and call_evaluate to api.rs

* [core] extract call method (#172)
@ascjones ascjones deleted the aj-add-ext-call-followup branch November 25, 2019 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants