Skip to content

🔧 Remove constraints_passed/constraints_results directive options #1396

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 4, 2025

Conversation

chrisjsewell
Copy link
Member

@chrisjsewell chrisjsewell commented Feb 1, 2025

These are post-processed internal fields, and so the directive options do not make sense and are in fact not used

Copy link

codecov bot commented Feb 1, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.24%. Comparing base (4e10030) to head (82976af).
Report is 130 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1396      +/-   ##
==========================================
+ Coverage   86.87%   88.24%   +1.36%     
==========================================
  Files          56       60       +4     
  Lines        6532     7145     +613     
==========================================
+ Hits         5675     6305     +630     
+ Misses        857      840      -17     
Flag Coverage Δ
pytests 88.24% <ø> (+1.36%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@chrisjsewell chrisjsewell merged commit 476d081 into master Feb 4, 2025
18 checks passed
@chrisjsewell chrisjsewell deleted the remove-need-options branch February 4, 2025 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants