Skip to content

Conversation

andreasmcdermott
Copy link
Member

No description provided.

@andreasmcdermott andreasmcdermott requested a review from Copilot May 30, 2025 22:38
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR refactors the formatting of output across multiple tool commands to use corrected entity JSON responses instead of custom string formatting. Key changes include:

  • Replacing calls to formatting utilities (e.g., formatAsUnorderedList) with toCorrectedEntity/toCorrectedEntities for a more structured output.
  • Removing unused formatting utility files and updating tests to verify JSON output.
  • Upgrading client search calls to request “full” detail for richer response data.

Reviewed Changes

Copilot reviewed 20 out of 20 changed files in this pull request and generated no comments.

Show a summary per file
File Description
src/tools/workflows.ts Updated workflow response formatting using toCorrectedEntity and toCorrectedEntities.
src/tools/workflows.test.ts Adjusted tests to use JSON output containment checks.
src/tools/user.ts Changed user response to use structured JSON output.
src/tools/user.test.ts Updated user tests accordingly.
src/tools/teams.ts Replaced custom member and workflow formatting with JSON response output.
src/tools/teams.test.ts Updated team tests to reflect structured output.
src/tools/stories.ts Refactored story output to return corrected entity JSON.
src/tools/stories.test.ts Modified tests to verify JSON response fields.
src/tools/objectives.ts Updated objectives output with structured JSON response.
src/tools/objectives.test.ts Adjusted tests to verify JSON formatted objectives.
src/tools/iterations.ts Refactored iteration responses for JSON output; updated tests accordingly.
src/tools/iterations.test.ts Modified tests to check for JSON response structure and field values.
src/tools/epics.ts Switched epic output to use corrected JSON entity responses.
src/tools/epics.test.ts Updated tests to verify epic response details in JSON.
src/tools/base.ts Added transformation functions to generate structured output, replacing old formatting routines.
src/tools/base.test.ts Added new tests for the corrected entity transformation functions.
src/client/shortcut.ts Updated search detail level from "slim" to "full" and added team caching.
package.json Bumped version from 0.6.1 to 0.7.0.
Comments suppressed due to low confidence (1)

src/tools/base.ts:51

  • Filtering an array of promises with .filter(Boolean) does not remove null values because promises are always truthy. Consider awaiting all promises first and then filtering the resolved values to remove nulls.
members: await Promise.all(member_ids.map((id) => this.correctMember(users.get(id))).filter(Boolean),)

@andreasmcdermott andreasmcdermott merged commit 3033af9 into main May 30, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant