Fix standalone gameserver definitions#103
Conversation
|
I think the build references a private repository of the maintainer, so they fail if I trigger them... maybe |
|
Just to understand, on game server you just use |
yancouto
left a comment
yancouto
left a comment
There was a problem hiding this comment.
Looks good, I'll finish review and push it later today or tomorrow.
| bool success = SteamGameServer_Init(ip, usGamePort, usQueryPort, eServerMode, version); | ||
| if (success) { | ||
| luasteam::init_Common(L); | ||
| luasteam::init_structs_auto(L); |
There was a problem hiding this comment.
This makes a lot of sense, it is indeed missing.
I just need to double check if there's something else that's also missing.
There was a problem hiding this comment.
SteamNetworkingMessage was also missing! I also updated the documentation. For what it's worth, with the fixes I added, everything in my game works as expected, including networking between several clients and servers using auth ticket handling and client handover.
| lua_createtable(L, 0, luasteam::GameServerUtils_count + 1); | ||
| register_Utils_auto(L, true); | ||
| add_func(L, "SetWarningMessageHook", luasteam_GameServerClient_SetWarningMessageHook); | ||
| lua_pushvalue(L, -1); |
There was a problem hiding this comment.
Hmm yeah, this was also wrong, but maybe it's missing from the non-gameserver as well. I will double check later and push the final fix. Hope it's not blocking you.
|
Thank you for taking a look at this! Exactly, my server is a completely stand-alone, dedicated server, so I dont want to have to run steam in the background. It is an intended use of the steam api. You use It works fine in the previous version of luasteam for what is worth. It's only blocking me in the sense that I can't update to the latest version of luasteam quite yet :) |
zorfmorf
changed the title
|
The gameserver initialization I fixed in a previous commit. Thanks for the docs fixes! I have manually merged this PR via c19ed10. PS. Future PRs will run the CI just fine, I fixed the problems with it. |
2 participants
Should fix #102
Things seem to work for me with these two changes, but honestly I am not too sure especially about the second change. The fix was suggested by AI and I am not certain if this is the best way to fix it ... yeah I know. In my defense, I haven't written any C++ in many years 🙇
So feel free to reject or change this PR