Feat: check if collection exists in database#102
Merged
kodumbeats merged 5 commits intomainfrom Jan 21, 2022
Merged
Conversation
kodumbeats
changed the title
eldadfux
reviewed
Jan 19, 2022
Member
eldadfux
left a comment
eldadfux
left a comment
There was a problem hiding this comment.
Very clean. I think the name is OK unless we think of something better. Left a few comments
TorstenDittmann
approved these changes
Jan 21, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since moving every collection to a single default database, we lose the ability to know if a collection has been properly configured (e.g. does the metadata table exist).
This PR extends
Utopia\Database\Database::exists()to optionally accept a collection name and test for its existence.Notes
I'm not sold on this, but the only other nice name I could come up with was
collectionExists()which doesn't fit the pattern. Alternative suggestions welcome.Testing
Unit tests have been added for both success and failure.