Fix: Symbols in binds#119
Merged
TorstenDittmann merged 12 commits intomainfrom May 12, 2022
Merged
Conversation
Contributor
Author
|
Mongo tests are currently failing. The reason is, we try to support I will need more feedback to decide what to do in this scenario. Do we want to drop support for dot in attribute name because of Mongo? |
wess
approved these changes
Apr 1, 2022
TorstenDittmann
requested changes
Apr 25, 2022
Contributor
Author
|
@TorstenDittmann Filter allows |
Contributor
That's fine, but we don't need a second array |
Contributor
Author
|
@TorstenDittmann Addressed. We now use only index, no map variable required. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

🚨 Breaking Change: Dot
.is no longer supported (key, collection, attribute, id...) 🚨Currently, if you create an attribute with a dash or dot
my-nameormy-name, the attribute is created. Problem is, if you try to createDocument or updateDocument, you get SQL query error:After this PR, binds are custom made and do not include attribute symbols. This resolved the problem and dashes/dots now work properly:
Issues: