Skip to content

Refactor permissions valdiators#177

Merged
christyjacob4 merged 18 commits intomainfrom
refactor-permission-validators
Sep 13, 2022
Merged

Refactor permissions valdiators#177
christyjacob4 merged 18 commits intomainfrom
refactor-permission-validators

Conversation

@abnegate
Copy link
Copy Markdown
Member

@abnegate abnegate commented Sep 5, 2022

  • Remove regex matching permissions/roles
  • Return specific error messages for invalid permissions/roles
  • Improve permissions/roles string parsing
  • Make status a dimension instead of role for consistency
    • status:verified-> users/verified
  • Add optional status param to user and users role helpers
  • Remove all legacy roles to avoid future migrations

@abnegate abnegate marked this pull request as ready for review September 8, 2022 05:15
…alidators

# Conflicts:
#	src/Database/Role.php
Comment thread src/Database/Database.php
Comment thread src/Database/Permission.php Outdated
Comment thread src/Database/Validator/Permissions.php Outdated
Comment thread src/Database/Validator/Permissions.php Outdated
Comment thread src/Database/Permission.php
Comment thread src/Database/Permission.php Outdated
Comment thread src/Database/Role.php Outdated
@christyjacob4 christyjacob4 merged commit 40c5cd4 into main Sep 13, 2022
@abnegate abnegate deleted the refactor-permission-validators branch November 23, 2023 01:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants