feat: update datetime filters issue#185
Merged
christyjacob4 merged 8 commits intomainfrom Sep 13, 2022
Merged
Conversation
christyjacob4
changed the base branch from
fix-force-datetime-filter
to
main
christyjacob4
commented
Sep 12, 2022
| throw new Exception('Default value ' . $default . ' does not match given type ' . $type); | ||
| } | ||
| break; | ||
| case self::VAR_DATETIME: |
Contributor
Author
There was a problem hiding this comment.
This is the only check for datetime. To ensure that datetime attribute allows a default value of type string
christyjacob4
commented
Sep 12, 2022
| $this->assertEquals(true, static::getDatabase()->createAttribute('attributes', 'integer_default', Database::VAR_INTEGER, 0, false, 1)); | ||
| $this->assertEquals(true, static::getDatabase()->createAttribute('attributes', 'float_default', Database::VAR_FLOAT, 0, false, 1.5)); | ||
| $this->assertEquals(true, static::getDatabase()->createAttribute('attributes', 'boolean_default', Database::VAR_BOOLEAN, 0, false, false)); | ||
| $this->assertEquals(true, static::getDatabase()->createAttribute('attributes', 'datetime_default', Database::VAR_DATETIME, 0, false, '2000-06-12T14:12:55.000+00:00', true, false, null, [], ['datetime'])); |
Contributor
Author
There was a problem hiding this comment.
When we create a datetime attribute, we should pass the filter explicitly..
Contributor
TorstenDittmann
left a comment
TorstenDittmann
left a comment
There was a problem hiding this comment.
I think if we add tests for required attributes it should be good 👍🏻
TorstenDittmann
approved these changes
Sep 12, 2022
Contributor
|
This closes #181 I believe |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.