Fix multiple ip issues on proxy servers#1
Fix multiple ip issues on proxy servers#1eldadfux merged 3 commits intoutopia-php:masterfrom lohanidamodar:fix-multiple-ips-on-proxy
Conversation
|
Does that even make sense? Why do they return multiple IPs? Which proxy server did that? |
TorstenDittmann
left a comment
There was a problem hiding this comment.
I would trim() the to be returned value.
From what I have read, there can be spaces 👍🏻
|
I talked briefly in meeting, In Digitalocean Apps Platform, you can check it https://appwrite-lite-t22pl.ondigitalocean.app/ |
|
@lohanidamodar I would also split the statement to two part and validate the [0] key is actually their (just to be on the safe side) using |
|
@lohanidamodar we should probably later add the same fix to utopia/framework request object |
done |
Will look into it |
|
@lohanidamodar looks good, waiting for the tests to pass 👌🏻 |
On a proxy server the header returns comma separated multiple IPs, where the first one is always the user's original IP.