Skip to content

added laravel/pint & configured as linter and formatter #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
christyjacob4 merged 3 commits into from
Oct 14, 2022
Merged

added laravel/pint & configured as linter and formatter #20

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2aceb84
added laravel/pint & configured as linter and formatter
magnaimn Oct 12, 2022
908b37a
fix: included formatted files and changed pint version to dev-main
magnaimn Oct 13, 2022
afabebd
Update composer.json
christyjacob4 Oct 14, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 20 additions & 0 deletions .github/workflows/linter.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
name: "Linter"

on: [pull_request]
jobs:
lint:
name: Linter
runs-on: ubuntu-latest

steps:
- name: Checkout repository
uses: actions/checkout@v3
with:
fetch-depth: 2

- run: git checkout HEAD^2

- name: Run Linter
run: |
docker run --rm -v $PWD:/app composer sh -c \
"composer install --profile --ignore-platform-reqs && composer lint"
7 changes: 6 additions & 1 deletion composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,13 @@
"autoload": {
"psr-4": {"Utopia\\System\\": "src/System"}
},
"scripts": {
"lint": "./vendor/bin/pint --test",
"format": "./vendor/bin/pint"
},
"require": {
"php": ">=7.4"
"php": ">=7.4",
"laravel/pint": "^1.2"
Copy link
Copy Markdown
Contributor

@Meldiron Meldiron Oct 13, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"laravel/pint": "^1.2"
"laravel/pint": "dev-main"

Let's please use this version to stay consistent with all other repositories.

Copy link
Copy Markdown
Author

@MagnaibayarMN MagnaibayarMN Oct 13, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, I fixed them. Could you please check it out.

},
"require-dev": {
"phpunit/phpunit": "^9.3",
Expand Down