Skip to content

macro use cleanup #125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 1, 2018
Merged

macro use cleanup #125

merged 1 commit into from
Feb 1, 2018

Conversation

@kinggoesgaming
Copy link
Member

@kinggoesgaming kinggoesgaming commented Feb 1, 2018

IntelliJ lints really help.

its mostly replacing try!(..) with ? and assert!(..) with assert_eq!(..) and assert_ne!(..)

@kinggoesgaming kinggoesgaming self-assigned this Feb 1, 2018
@kinggoesgaming
Copy link
Member Author

kinggoesgaming commented Feb 1, 2018

bors: r+

bors bot added a commit that referenced this pull request Feb 1, 2018
@bors
Merge #125
3db7ab6 
125: macro use cleanup r=kinggoesgaming a=kinggoesgaming

IntelliJ lints really help. 

its mostly replacing `try!(..)` with `?` and `assert!(..)` with `assert_eq!(..)` and `assert_ne!(..)`
@bors
Copy link
Contributor

bors bot commented Feb 1, 2018

Build succeeded

@bors bors bot merged commit 069f8aa into master Feb 1, 2018
@kinggoesgaming kinggoesgaming deleted the macro-cleanup branch February 1, 2018 05:55
@kinggoesgaming kinggoesgaming modified the milestones: 0.6.0, 0.6.0-beta Feb 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@kinggoesgaming kinggoesgaming

Labels

None yet

Projects

None yet

Milestone

0.6.0-beta

Development

Successfully merging this pull request may close these issues.

2 participants

@kinggoesgaming