Use cfg-if to create logical feature gate implementations #167
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* [x] `extern crate`s * [x] already provided `mod`s Signed-off-by: Hunar Roop Kahlon <[email protected]>
Signed-off-by: Hunar Roop Kahlon <[email protected]>
Signed-off-by: Hunar Roop Kahlon <[email protected]>
Signed-off-by: Hunar Roop Kahlon <[email protected]>
Signed-off-by: Hunar Roop Kahlon <[email protected]>
Signed-off-by: Hunar Roop Kahlon <[email protected]>
kinggoesgaming
requested review from
Dylan-DPC-zz,
KodrAus and
radix
as code owners
Member
Author
|
question: should I put various feature gated constructor |
Member
Author
|
@uuid-rs/uuid I think this is logical enough for this PR. Should be ready for review and merge |
kinggoesgaming
changed the title
KodrAus
reviewed
Mar 14, 2018
Member
KodrAus
left a comment
KodrAus
left a comment
There was a problem hiding this comment.
This looks a lot easier to follow! Just had a quick scan through on mobile
| } | ||
| } | ||
|
|
||
| cfg_if! { |
Member
There was a problem hiding this comment.
Maybe we could reduce some duplicated nesting here by conditionally using core as std:
if #[cfg(not(feature = "std"))] {
use core as std;
}
use std::fmt;
use std::str;
...What do you think?
Member
Author
There was a problem hiding this comment.
This PR was intended to switch to cfg_if. Another PR should make the that part more readable later... which I think I will have ready soon
Dylan-DPC-zz
approved these changes
Mar 14, 2018
Member
|
bors: r+ |
bors bot
added a commit
that referenced
this pull request
Mar 14, 2018
167: Use cfg-if to create logical feature gate implementations r=Dylan-DPC a=kinggoesgaming
<!--
As we are working towards a stable version of uuid, we require that you
open an issue, before submitting a pull request. If the pull request is
imcomplete, prepend the Title with WIP:
-->
**I'm submitting a ...**
- [ ] bug fix
- [ ] feature enhancement
- [ ] deprecation or removal
- [x] refactor
# Description
`uuid` now adds `cfg-if` as a dependency. With this, `#[cfg(..)]` implementations are easier to understand, as they can be handled in a more logical view because the macro allows us to `if` statements to make the checks more rustic at the source level
# Motivation
Understanding feature gate implementation becomes easier.
# Tests
The CI builds passing should be plenty.
# Related Issue(s)
#147
Contributor
Build failed |
Member
Author
|
clippy was outdated, cache cleared bors r+ |
bors bot
added a commit
that referenced
this pull request
Mar 14, 2018
167: Use cfg-if to create logical feature gate implementations r=kinggoesgaming a=kinggoesgaming
<!--
As we are working towards a stable version of uuid, we require that you
open an issue, before submitting a pull request. If the pull request is
imcomplete, prepend the Title with WIP:
-->
**I'm submitting a ...**
- [ ] bug fix
- [ ] feature enhancement
- [ ] deprecation or removal
- [x] refactor
# Description
`uuid` now adds `cfg-if` as a dependency. With this, `#[cfg(..)]` implementations are easier to understand, as they can be handled in a more logical view because the macro allows us to `if` statements to make the checks more rustic at the source level
# Motivation
Understanding feature gate implementation becomes easier.
# Tests
The CI builds passing should be plenty.
# Related Issue(s)
#147
Contributor
Build failed |
Member
Author
|
again! wrong cache cleared :( bors r+ |
bors bot
added a commit
that referenced
this pull request
Mar 14, 2018
167: Use cfg-if to create logical feature gate implementations r=kinggoesgaming a=kinggoesgaming
<!--
As we are working towards a stable version of uuid, we require that you
open an issue, before submitting a pull request. If the pull request is
imcomplete, prepend the Title with WIP:
-->
**I'm submitting a ...**
- [ ] bug fix
- [ ] feature enhancement
- [ ] deprecation or removal
- [x] refactor
# Description
`uuid` now adds `cfg-if` as a dependency. With this, `#[cfg(..)]` implementations are easier to understand, as they can be handled in a more logical view because the macro allows us to `if` statements to make the checks more rustic at the source level
# Motivation
Understanding feature gate implementation becomes easier.
# Tests
The CI builds passing should be plenty.
# Related Issue(s)
#147
Contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm submitting a ...
Description
uuidnow addscfg-ifas a dependency. With this,#[cfg(..)]implementations are easier to understand, as they can be handled in a more logical view because the macro allows us toifstatements to make the checks more rustic at the source levelMotivation
Understanding feature gate implementation becomes easier.
Tests
The CI builds passing should be plenty.
Related Issue(s)
#147