move slog implementation into its own module #185
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Hunar Roop Kahlon <[email protected]>
kinggoesgaming
requested review from
Dylan-DPC-zz,
KodrAus and
radix
as code owners
Dylan-DPC-zz
approved these changes
Mar 26, 2018
Member
Author
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Mar 26, 2018
185: move slog implementation into its own module r=kinggoesgaming a=kinggoesgaming **I'm submitting a ...** - [ ] bug fix - [ ] feature enhancement - [ ] deprecation or removal - [x] refactor # Description The slog impl and tests are moved into `slog_support` module # Motivation As part of the refactor effort, feature gated implementations need to be moved into their own modules. # Tests Current provided tests are passing # Related Issue(s) #124
Contributor
bors bot
added a commit
that referenced
this pull request
May 30, 2018
255: slog feature added to CI r=kinggoesgaming a=Dylan-DPC **I'm submitting a ...** - [ ] bug fix - [x] feature enhancement - [ ] deprecation or removal - [ ] refactor # Description Add slog feature to CI # Motivation # Tests 1 build added to CI process # Related Issue(s) Fixes #252 #185 Co-authored-by: dylan_DPC <[email protected]> Co-authored-by: Dylan DPC <[email protected]>
LinusU
pushed a commit
to LinusU/uuid
that referenced
this pull request
Feb 26, 2020
…uid-rs#221) * use typeof to check for crypto rather than global. Fixes uuid-rs#185 * fix test(s) for node v0.12 * tweak
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm submitting a ...
Description
The slog impl and tests are moved into
slog_supportmoduleMotivation
As part of the refactor effort, feature gated implementations need to be moved into their own modules.
Tests
Current provided tests are passing
Related Issue(s)
#124