Move namespaces into uuid::ns #187
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Hunar Roop Kahlon <[email protected]>
kinggoesgaming
requested review from
Dylan-DPC-zz,
KodrAus and
radix
as code owners
Dylan-DPC-zz
approved these changes
Mar 27, 2018
Member
Author
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Mar 27, 2018
187: Move namespaces into uuid::ns r=kinggoesgaming a=kinggoesgaming **I'm submitting a ...** - [ ] bug fix - [ ] feature enhancement - [ ] deprecation or removal - [x] refactor # Description Moves `NAMESPACE_DNS`, `NAMESPACE_OID`, `NAMESPACE_URL` and `NAMESPACE_X500` into `uuid::ns` module. The namespaces are not exposed as part of the prelude, as people only may need one of the namespaces when they do need them. # Motivation Part of the refactor efforts # Tests Current tests are passing. # Related Issue(s) #124
Contributor
kinggoesgaming
added
breaking
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm submitting a ...
Description
Moves
NAMESPACE_DNS,NAMESPACE_OID,NAMESPACE_URLandNAMESPACE_X500intouuid::nsmodule. The namespaces are not exposed as part of the prelude, as people only may need one of the namespaces when they do need them.Motivation
Part of the refactor efforts
Tests
Current tests are passing.
Related Issue(s)
#124