Add optional arbitrary impl #550
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kinggoesgaming
requested changes
Nov 1, 2021
Member
kinggoesgaming
left a comment
kinggoesgaming
left a comment
There was a problem hiding this comment.
Other than removing the mailing list (since you touched that file), everything looks good
kinggoesgaming
approved these changes
Nov 1, 2021
Member
Author
|
Thanks for the review @kinggoesgaming! I've been hammering at these last mile stabilization tasks so have made a huge pile of basically unreviewable changes. I was going to open a PR that prepares for our |
Member
|
Should be good! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #514
Adds an optional implementation of the stable
Arbitrarytrait toUuidso it can be used for fuzzing.We always give you a valid V4 UUID from the input, unless there aren't enough bytes.
I've also streamlined some of our templates a bit, since I find myself removing most of the scaffolding when writing PRs and issues.