Replace derive(Hash) with manual impl in Uuid #824
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@KodrAus, its done i believe, but iam not shure if the other uses of derive(Hash) should also be removed. |
Member
|
Hi @diopoex 🖐🏼 I think for starters, this should be good. If this implementation change does not cause issues (it shouldn't, but you never know), another PR can do it for the rest. |
Contributor
Author
|
Hey @kinggoesgaming Iam open to do it for where it makes sense so that the issue is completed and that we do not have an inconsistent solution. But lets see! |
kodiakhq bot
pushed a commit
to pdylanross/fatigue
that referenced
this pull request
May 23, 2025
Bumps uuid from 1.16.0 to 1.17.0. Release notes Sourced from uuid's releases. v1.17.0 What's Changed Added convenience implementation TryFrom for std by @Nahuel-M in uuid-rs/uuid#819 Update OSX builds to arm by @KodrAus in uuid-rs/uuid#825 Replace derive(Hash) with manual impl in Uuid by @diopoex in uuid-rs/uuid#824 Add wasm32v1-none Support by @bushrat011899 in uuid-rs/uuid#828 Prepare for 1.17.0 release by @KodrAus in uuid-rs/uuid#829 New Contributors @Nahuel-M made their first contribution in uuid-rs/uuid#819 @diopoex made their first contribution in uuid-rs/uuid#824 Full Changelog: uuid-rs/[email protected] Commits 2fd9b61 Merge pull request #829 from uuid-rs/cargo/v1.17.0 ed0d385 prepare for 1.17.0 release c54cadc Merge pull request #828 from bushrat011899/wasm32v1-none 625d769 Fix typo in MVP Web CI 9d638e0 Add MVP Web CI Task 83dc528 Add wasm32v1-none support 5fbd843 Merge pull request #824 from diopoex/main 6635ae4 Merge pull request #825 from uuid-rs/ci/aarch64-apple-darwin b2370f2 update toolchain for outdated job c74ad33 update OSX builds to arm Additional commits viewable in compare view Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase. Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: @dependabot rebase will rebase this PR @dependabot recreate will recreate this PR, overwriting any edits that have been made to it @dependabot merge will merge this PR after your CI passes on it @dependabot squash and merge will squash and merge this PR after your CI passes on it @dependabot cancel merge will cancel a previously requested merge and block automerging @dependabot reopen will reopen this PR if it is closed @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My attempt to solve #775.
I am not sure about the following two things: