Unsafe cleanup #841
Merged
Unsafe cleanup #841
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove a number of `unsafe` blocks, replacing them with uses of zerocopy. In order to do this, we stabilize zerocopy as a (non-optional) dependency. Closes #588
kodiakhq bot
pushed a commit
to pdylanross/fatigue
that referenced
this pull request
Sep 3, 2025
Bumps uuid from 1.18.0 to 1.18.1. Release notes Sourced from uuid's releases. v1.18.1 What's Changed Unsafe cleanup by @KodrAus in uuid-rs/uuid#841 Prepare for 1.18.1 release by @KodrAus in uuid-rs/uuid#842 Full Changelog: uuid-rs/[email protected] Commits 50d8e79 Merge pull request #842 from uuid-rs/cargo/v1.18.1 7948592 prepare for 1.18.1 release 6d847c7 Merge pull request #841 from uuid-rs/chore/unsafe-cleanup 675cccc re-gate zerocopy behind unstable feature flag 4dd5828 Remove some unsafe; stabilize zerocopy See full diff in compare view Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase. Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: @dependabot rebase will rebase this PR @dependabot recreate will recreate this PR, overwriting any edits that have been made to it @dependabot merge will merge this PR after your CI passes on it @dependabot squash and merge will squash and merge this PR after your CI passes on it @dependabot cancel merge will cancel a previously requested merge and block automerging @dependabot reopen will reopen this PR if it is closed @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re-working of #833
This PR takes the work by @joshlf and re-gates
zeropcopysupport behind a feature flag since we can't publicly depend on its unstable API yet. To make it easier for us to usezerocopyor some standard subset of its functionality in the future, I've just wrapped up the few calls we make to its macros intotransmutes whenzerocopyis unavailable, andzerocopycalls when it is. This is still a nice step forward for the library, because we testzerocopyin CI, and so any attempt at an invalid transmute in the code will at least be caught there (and hopefully bymiritoo).