Skip to content

Fix tail -c panics when requested bytes exceed file size#10268

Merged
ChrisDryden merged 3 commits into
uutils:mainfrom
dhr412:main
Jan 17, 2026
Merged

Fix tail -c panics when requested bytes exceed file size#10268
ChrisDryden merged 3 commits into
uutils:mainfrom
dhr412:main

Conversation

@dhr412

@dhr412 dhr412 commented Jan 16, 2026

Copy link
Copy Markdown
Contributor

This supersedes PR #10211 which was closed accidentally
Closes #10183

@dhr412

dhr412 commented Jan 16, 2026

Copy link
Copy Markdown
Contributor Author

@ChrisDryden Is the test okay now?

@codspeed-hq

codspeed-hq Bot commented Jan 16, 2026

Copy link
Copy Markdown

CodSpeed Performance Report

Merging this PR will degrade performance by 3.96%

Comparing dhr412:main (6dc4ae5) with main (a1545ef)

Summary

❌ 2 regressed benchmarks
✅ 280 untouched benchmarks
⏩ 38 skipped benchmarks1

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Mode Benchmark BASE HEAD Efficiency
Memory cp_large_file[16] 115.3 KB 120.1 KB -3.96%
Memory numfmt_large_numbers_si[10000] 4.6 MB 4.8 MB -3.92%

Footnotes

  1. 38 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@oech3

This comment was marked as resolved.

@github-actions

Copy link
Copy Markdown

GNU testsuite comparison:

Note: The gnu test tests/printf/printf-surprise is now being skipped but was previously passing.

@ChrisDryden
ChrisDryden merged commit 7707b72 into uutils:main Jan 17, 2026
156 of 157 checks passed
@ChrisDryden

Copy link
Copy Markdown
Collaborator

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

tail: -c panics when requested bytes exceed file size

3 participants