Skip to content

numfmt: fix #11935 --invalid=warn/ignore/fail ignores mode when rejecting scientific notation#11945

Merged
cakebaker merged 6 commits into
uutils:mainfrom
Devel08:fix-#11935
Apr 23, 2026
Merged

numfmt: fix #11935 --invalid=warn/ignore/fail ignores mode when rejecting scientific notation#11945
cakebaker merged 6 commits into
uutils:mainfrom
Devel08:fix-#11935

Conversation

@Devel08

@Devel08 Devel08 commented Apr 22, 2026

Copy link
Copy Markdown
Contributor

This PR resolves #11935.

When I fixed the issue where scientific notation is accepted, but it shouldn't be, I manually returned an error instead of letting "result" to do that. I fixed that and I apologize.
Ran cargo fmt and cargo test.

@cakebaker cakebaker changed the title fix #11935 numfmt: fix #11935 Apr 22, 2026
@Devel08 Devel08 marked this pull request as draft April 22, 2026 15:05
@sylvestre sylvestre changed the title numfmt: fix #11935 numfmt: fix #11935 --invalid=warn/ignore/fail ignores mode when rejecting scientific notation Apr 22, 2026
@github-actions

github-actions Bot commented Apr 22, 2026

Copy link
Copy Markdown

GNU testsuite comparison:

Skip an intermittent issue tests/date/date-locale-hour (fails in this run but passes in the 'main' branch)
Skip an intermittent issue tests/date/resolution (fails in this run but passes in the 'main' branch)
Skipping an intermittent issue tests/cut/bounded-memory (passes in this run but fails in the 'main' branch)
Skipping an intermittent issue tests/tail/pipe-f (passes in this run but fails in the 'main' branch)
Skipping an intermittent issue tests/tail/symlink (passes in this run but fails in the 'main' branch)

@codspeed-hq

codspeed-hq Bot commented Apr 22, 2026

Copy link
Copy Markdown

Merging this PR will improve performance by 31.27%

⚡ 1 improved benchmark
✅ 267 untouched benchmarks
⏩ 87 skipped benchmarks1

Performance Changes

Mode Benchmark BASE HEAD Efficiency
Memory cp_recursive_deep_tree[(120, 4)] 699.2 KB 532.7 KB +31.27%

Comparing Devel08:fix-#11935 (6687a1c) with main (22bd036)

Open in CodSpeed

Footnotes

  1. 87 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@Devel08 Devel08 marked this pull request as ready for review April 22, 2026 15:39
@cakebaker

Copy link
Copy Markdown
Contributor

Can you please add a test to tests/by_util/test_numfmt.rs to ensure we don't regress in the future? Thanks.

@Devel08

Devel08 commented Apr 23, 2026

Copy link
Copy Markdown
Contributor Author

@cakebaker Sure

Comment thread tests/by-util/test_numfmt.rs Outdated
@cakebaker cakebaker merged commit d836730 into uutils:main Apr 23, 2026
168 of 169 checks passed
@cakebaker

Copy link
Copy Markdown
Contributor

Thanks!

@Devel08 Devel08 deleted the fix-#11935 branch April 24, 2026 03:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

numfmt: --invalid=warn/ignore/fail ignores mode when rejecting scientific notation

2 participants