Skip to content

deps: remove unnecessary package fields#11968

Merged
sylvestre merged 1 commit into
uutils:mainfrom
xtqqczze:qodana/CargoUnnecessaryPackageKey
May 20, 2026
Merged

deps: remove unnecessary package fields#11968
sylvestre merged 1 commit into
uutils:mainfrom
xtqqczze:qodana/CargoUnnecessaryPackageKey

Conversation

@xtqqczze

Copy link
Copy Markdown
Contributor

No description provided.

@github-actions

github-actions Bot commented Apr 24, 2026

Copy link
Copy Markdown

GNU testsuite comparison:

Skip an intermittent issue tests/tail/symlink (fails in this run but passes in the 'main' branch)
Skipping an intermittent issue tests/tail/tail-n0f (passes in this run but fails in the 'main' branch)
Note: The gnu test tests/basenc/bounded-memory is now being skipped but was previously passing.
Congrats! The gnu test tests/rm/many-dir-entries-vs-OOM is now passing!

@xtqqczze xtqqczze force-pushed the qodana/CargoUnnecessaryPackageKey branch from ed18b8d to 895de50 Compare April 24, 2026 00:27
@codspeed-hq

codspeed-hq Bot commented Apr 24, 2026

Copy link
Copy Markdown

Merging this PR will not alter performance

✅ 309 untouched benchmarks
⏩ 46 skipped benchmarks1


Comparing xtqqczze:qodana/CargoUnnecessaryPackageKey (895de50) with main (52e1bc1)

Open in CodSpeed

Footnotes

  1. 46 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@sylvestre sylvestre left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM — the package field is redundant when it matches the key name.

@sylvestre sylvestre left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM — the package field is redundant when it matches the key name.

@sylvestre sylvestre merged commit 157bbab into uutils:main May 20, 2026
170 checks passed
@xtqqczze xtqqczze deleted the qodana/CargoUnnecessaryPackageKey branch May 20, 2026 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants