Skip to content

process: replace getuid with rustix::process::getuid#12094

Merged
sylvestre merged 1 commit into
uutils:mainfrom
Franklin-Qi:fix-bug#12042-replace-getuid-with-rustix
May 16, 2026
Merged

process: replace getuid with rustix::process::getuid#12094
sylvestre merged 1 commit into
uutils:mainfrom
Franklin-Qi:fix-bug#12042-replace-getuid-with-rustix

Conversation

@Franklin-Qi

Copy link
Copy Markdown
Contributor

replace nix::unistd::getuid with rustix::process::getuid

closed: #12042

replace nix::unistd::getuid with rustix::process::getuid
@oech3

oech3 commented Apr 30, 2026

Copy link
Copy Markdown
Contributor

Is uid_t correct?

@oech3

oech3 commented Apr 30, 2026

Copy link
Copy Markdown
Contributor

It would be nice to replace other get*id()'s (if it is possible with small diff).

@github-actions

Copy link
Copy Markdown

GNU testsuite comparison:

Skip an intermittent issue tests/date/date-locale-hour (fails in this run but passes in the 'main' branch)
Skip an intermittent issue tests/rm/isatty (fails in this run but passes in the 'main' branch)
Congrats! The gnu test tests/tail/retry is no longer failing!
Note: The gnu test tests/expand/bounded-memory is now being skipped but was previously passing.
Note: The gnu test tests/env/env-signal-handler was skipped on 'main' but is now failing.

@xtqqczze

Copy link
Copy Markdown
Contributor

Is uid_t correct?

It should be rustix::process::RawUid

@oech3

oech3 commented May 3, 2026

Copy link
Copy Markdown
Contributor

I would remove those uucore wrappers (just for .as_raw()) and directly use rustix.

@xtqqczze

xtqqczze commented May 4, 2026

Copy link
Copy Markdown
Contributor

I would remove those uucore wrappers (just for .as_raw()) and directly use rustix.

Yes in theory, if these functions aren't used by other consumers of uucore.

@sylvestre
sylvestre merged commit c90f1ea into uutils:main May 16, 2026
167 checks passed
nonontb pushed a commit to nonontb/coreutils that referenced this pull request May 28, 2026
replace nix::unistd::getuid with rustix::process::getuid
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

replace getuid with rustix::process:getuid

4 participants