Skip to content

split: remove Box<dyn Read>#13095

Closed
oech3 wants to merge 2 commits into
uutils:mainfrom
oech3:split-boxr
Closed

split: remove Box<dyn Read>#13095
oech3 wants to merge 2 commits into
uutils:mainfrom
oech3:split-boxr

Conversation

@oech3

@oech3 oech3 commented Jun 26, 2026

Copy link
Copy Markdown
Contributor

This is needed to define .as_fd() to enable io::copy's specialization (e.g. reflink via copy_file_range).
Part of #13073 .

@github-actions

github-actions Bot commented Jun 26, 2026

Copy link
Copy Markdown

GNU testsuite comparison:

Skip an intermittent issue tests/cut/bounded-memory (fails in this run but passes in the 'main' branch)
Note: The gnu test tests/csplit/csplit-heap is now being skipped but was previously passing.

@codspeed-hq

codspeed-hq Bot commented Jun 26, 2026

Copy link
Copy Markdown

Merging this PR will degrade performance by 84.15%

⚠️ Different runtime environments detected

Some benchmarks with significant performance changes were compared across different runtime environments,
which may affect the accuracy of the results.

Open the report in CodSpeed to investigate

⚡ 1 improved benchmark
❌ 1 regressed benchmark
✅ 6 untouched benchmarks
⏩ 378 skipped benchmarks1

Warning

Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Mode Benchmark BASE HEAD Efficiency
Simulation split_number_chunks 132 µs 5,452.7 µs -97.58%
Simulation split_bytes 282.6 µs 272.4 µs +3.75%

Tip

Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.


Comparing oech3:split-boxr (ce1fcc2) with main (a60058c)

Open in CodSpeed

Footnotes

  1. 378 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@oech3 oech3 closed this Jun 26, 2026
@oech3 oech3 reopened this Jul 3, 2026
@oech3 oech3 force-pushed the split-boxr branch 2 times, most recently from a594532 to c71e9cd Compare July 3, 2026 11:52
@oech3 oech3 closed this Jul 3, 2026
@oech3 oech3 deleted the split-boxr branch July 3, 2026 12:34
@oech3 oech3 restored the split-boxr branch July 15, 2026 08:41
@oech3 oech3 reopened this Jul 15, 2026
@oech3 oech3 force-pushed the split-boxr branch 2 times, most recently from 17b5c47 to ce1fcc2 Compare July 15, 2026 08:48
@oech3 oech3 closed this Jul 15, 2026
@oech3 oech3 deleted the split-boxr branch July 15, 2026 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant