Implement md5sum (closes #47) #143
Merged
+204
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| if binary { | ||
| safe_unwrap!(file.read_to_end()) | ||
| } else { | ||
| let val = safe_unwrap!(file.read_to_str()).into_bytes(); // XXX: i don't know why the variable is necessary |
There was a problem hiding this comment.
This is almost certainly rust-lang/rust#5941, you can work around it via
(safe_unwrap!(file.read_to_str())).into_bytes()There was a problem hiding this comment.
Thank you very much. Now it makes sense as to why that's happening.
|
Yep, that's the plan. :) |
jbcrail
pushed a commit
to jbcrail/coreutils
that referenced
this pull request
Apr 29, 2015
Implement md5sum (closes uutils#47)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To get this to work, I had to add @DaGenix's
rust-cryptoas a submodule. This required some fairly significant changes to the Makefile, mainly revolving around adding the ability to execute custom Makefiles for the utilities that need them (seemd5sumfor an example).This is also fixes
truncatefor the latest Rust.