Use Duration based uptime across uucore
#7926
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
you probably noticed that a few jobs are failing |
Author
Oh yes, just getting a draft PR on the issue now while I work on it, this commit won't build yet. I'll mark ready for review when it's good enough to look at. |
irbeam256
force-pushed
the
7851_uptime_duration
branch
from
c59820d to
177fae1
Compare
Author
|
This PR depends on the changes in #7910 so once that is merged I can rebase this branch on main. |
|
GNU testsuite comparison: |
drinkcat
reviewed
May 29, 2025
| if upsecs >= 0 { | ||
| print_uptime(Some(upsecs))?; | ||
| let uptime = get_uptime(None); | ||
| if uptime.is_ok() >= 0 { |
Collaborator
There was a problem hiding this comment.
This can't be negative anymore, right?
So maybe if let Some(uptime) = uptime { would be easier.
Collaborator
|
I think 177fae1 looks good, would it be possible to rebase just that commit on |
Contributor
|
it has been draft for a long time, please reopen when ready |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #7851
Changes the
i64based uptime returned by uucore'sget_uptimeinto anstd::time::Durationand updates callsites.get_uptimemodified to accept fractional seconds from/proc/uptimeand returnDurationuucore/.../features/uptime.rsanduu/.../uptime.rsuse Duration