Skip to content

mv: support moving folder containing symlinks to different filesystem#8605

Merged
sylvestre merged 3 commits into
uutils:mainfrom
yuankunzhang:mv-folder-containing-symlinks-across-fs
Jan 1, 2026
Merged

mv: support moving folder containing symlinks to different filesystem#8605
sylvestre merged 3 commits into
uutils:mainfrom
yuankunzhang:mv-folder-containing-symlinks-across-fs

Conversation

@yuankunzhang

Copy link
Copy Markdown
Contributor

Closes #8586.

@yuankunzhang
yuankunzhang force-pushed the mv-folder-containing-symlinks-across-fs branch 3 times, most recently from ef80a6d to 20d8165 Compare September 12, 2025 13:51
@github-actions

Copy link
Copy Markdown

GNU testsuite comparison:

Skip an intermittent issue tests/misc/tee (fails in this run but passes in the 'main' branch)
Skipping an intermittent issue tests/misc/stdbuf (passes in this run but fails in the 'main' branch)

@yuankunzhang
yuankunzhang force-pushed the mv-folder-containing-symlinks-across-fs branch from 20d8165 to 02cca37 Compare September 13, 2025 13:12
Comment thread src/uu/mv/src/mv.rs
Comment thread tests/by-util/test_mv.rs
@yuankunzhang
yuankunzhang force-pushed the mv-folder-containing-symlinks-across-fs branch 4 times, most recently from 91c048d to 7e163fc Compare September 27, 2025 14:23
@github-actions

Copy link
Copy Markdown

GNU testsuite comparison:

Skipping an intermittent issue tests/misc/tee (passes in this run but fails in the 'main' branch)

@codspeed-hq

codspeed-hq Bot commented Sep 27, 2025

Copy link
Copy Markdown

CodSpeed Performance Report

Merging #8605 will not alter performance

Comparing yuankunzhang:mv-folder-containing-symlinks-across-fs (35848e2) with main (1eea517)

Summary

✅ 136 untouched
⏩ 24 skipped1

Footnotes

  1. 24 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@yuankunzhang
yuankunzhang force-pushed the mv-folder-containing-symlinks-across-fs branch 3 times, most recently from b883bf1 to a4ed94c Compare October 1, 2025 14:27
@github-actions

github-actions Bot commented Oct 1, 2025

Copy link
Copy Markdown

GNU testsuite comparison:

Skip an intermittent issue tests/misc/tee (fails in this run but passes in the 'main' branch)

@yuankunzhang
yuankunzhang force-pushed the mv-folder-containing-symlinks-across-fs branch from a4ed94c to 8b1b869 Compare October 1, 2025 14:53
@oech3

This comment was marked as resolved.

@yuankunzhang
yuankunzhang force-pushed the mv-folder-containing-symlinks-across-fs branch 2 times, most recently from 04dc5c7 to 9340bf4 Compare November 21, 2025 10:08
@oech3

oech3 commented Nov 23, 2025

Copy link
Copy Markdown
Contributor

Should we share codebase with cp -a instead?
It should fix #9458 automatically

@yuankunzhang
yuankunzhang force-pushed the mv-folder-containing-symlinks-across-fs branch from 9340bf4 to a01ee76 Compare December 1, 2025 04:38
@github-actions

github-actions Bot commented Dec 1, 2025

Copy link
Copy Markdown

GNU testsuite comparison:

Skip an intermittent issue tests/tail/overlay-headers (fails in this run but passes in the 'main' branch)

@oech3

oech3 commented Dec 5, 2025

Copy link
Copy Markdown
Contributor

Would you merge this at fix 1 bug at a monent? sudo test issue is traced at different PR and difficult to fix at here.

@oech3

oech3 commented Dec 16, 2025

Copy link
Copy Markdown
Contributor

Would you merge this?

@oech3

oech3 commented Dec 20, 2025

Copy link
Copy Markdown
Contributor

@yuankunzhang @ChrisDryden Would you test mkdir /tmp/{a,b}; unshare -rm bash -c "mount -t tmpfs tmpfs /tmp/a && mount -t tmpfs tmpfs /tmp/b && mkdir -p /tmp/a/d && ln -sv miss /tmp/a/d/dang && mv -v /tmp/a/d /tmp/b" without sudo?

@uutils uutils deleted a comment from github-actions Bot Dec 26, 2025
@uutils uutils deleted a comment from github-actions Bot Dec 26, 2025
@uutils uutils deleted a comment from github-actions Bot Dec 26, 2025
@uutils uutils deleted a comment from github-actions Bot Dec 26, 2025
@uutils uutils deleted a comment from github-actions Bot Dec 26, 2025
@uutils uutils deleted a comment from github-actions Bot Dec 26, 2025
@oech3

oech3 commented Dec 31, 2025

Copy link
Copy Markdown
Contributor

The job has exceeded the maximum execution time while awaiting a runner for 24h0m0s

@oech3

oech3 commented Jan 1, 2026

Copy link
Copy Markdown
Contributor

ok to merge this pr?

@github-actions

github-actions Bot commented Jan 1, 2026

Copy link
Copy Markdown

GNU testsuite comparison:

GNU test failed: tests/tty/tty-eof. tests/tty/tty-eof is passing on 'main'. Maybe you have to rebase?

@sylvestre
sylvestre merged commit cc389e5 into uutils:main Jan 1, 2026
128 of 129 checks passed
@oech3

oech3 commented Jan 1, 2026

Copy link
Copy Markdown
Contributor

Thanyou!

@oech3

oech3 commented Jan 1, 2026

Copy link
Copy Markdown
Contributor

Still mv: Operation not supported (os error 95) for me. Maybe, dir on compressed btrfs specific?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

mv: 0.2.0 mv cannot move directory with symlink to tmpfs mountpoint

4 participants