Skip to content

ls: Proper alignment for capabilities and ACLs notifications#8793

Merged
Ecordonnier merged 8 commits into
uutils:mainfrom
kimono-koans:proper_alignment
Jan 14, 2026
Merged

ls: Proper alignment for capabilities and ACLs notifications#8793
Ecordonnier merged 8 commits into
uutils:mainfrom
kimono-koans:proper_alignment

Conversation

@kimono-koans

Copy link
Copy Markdown
Contributor

Fixes: #8792

@github-actions

github-actions Bot commented Oct 2, 2025

Copy link
Copy Markdown

GNU testsuite comparison:

Skipping an intermittent issue tests/timeout/timeout (passes in this run but fails in the 'main' branch)

@codspeed-hq

codspeed-hq Bot commented Oct 2, 2025

Copy link
Copy Markdown

CodSpeed Performance Report

Merging #8793 will not alter performance

Comparing kimono-koans:proper_alignment (5208045) with main (2d718f2)

Summary

✅ 127 untouched
⏩ 6 skipped1

Footnotes

  1. 6 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@sylvestre

Copy link
Copy Markdown
Contributor

Could you please add a test to make sure we don't regress? Thanks

@github-actions

github-actions Bot commented Oct 5, 2025

Copy link
Copy Markdown

GNU testsuite comparison:

Skip an intermittent issue tests/tail/overlay-headers (fails in this run but passes in the 'main' branch)

@github-actions

github-actions Bot commented Oct 5, 2025

Copy link
Copy Markdown

GNU testsuite comparison:

Skip an intermittent issue tests/tail/overlay-headers (fails in this run but passes in the 'main' branch)
Skipping an intermittent issue tests/misc/tee (passes in this run but fails in the 'main' branch)

1 similar comment
@github-actions

github-actions Bot commented Oct 5, 2025

Copy link
Copy Markdown

GNU testsuite comparison:

Skip an intermittent issue tests/tail/overlay-headers (fails in this run but passes in the 'main' branch)
Skipping an intermittent issue tests/misc/tee (passes in this run but fails in the 'main' branch)

@github-actions

Copy link
Copy Markdown

GNU testsuite comparison:

Skip an intermittent issue tests/tail/overlay-headers (fails in this run but passes in the 'main' branch)
Skipping an intermittent issue tests/misc/tee (passes in this run but fails in the 'main' branch)

@Ecordonnier

Copy link
Copy Markdown
Collaborator

This seems to work correctly:

with this PR:

ecordonnier@lj8k2dq3:~/dev/coreutils$ ./test_acl.sh 
+ rm -rf test_acl
+ mkdir test_acl
+ cd test_acl
+ touch file_no_acl
+ touch file_with_acl
+ setfacl -m u:nobody:r file_with_acl
+ ls -l
total 0
-rw-rw-r--  1 ecordonnier ecordonnier 0 Jan 14 11:54 file_no_acl
-rw-rw-r--+ 1 ecordonnier ecordonnier 0 Jan 14 11:54 file_with_acl
+ ../target/debug/ls -l
total 0
-rw-rw-r--  1 ecordonnier ecordonnier 0 Jan 14 11:54 file_no_acl
-rw-rw-r--+ 1 ecordonnier ecordonnier 0 Jan 14 11:54 file_with_acl

with main 22069bb (without this PR merged):

ecordonnier@lj8k2dq3:~/dev/coreutils$ ./test_acl.sh 
+ rm -rf test_acl
+ mkdir test_acl
+ cd test_acl
+ touch file_no_acl
+ touch file_with_acl
+ setfacl -m u:nobody:r file_with_acl
+ ls -l
total 0
-rw-rw-r--  1 ecordonnier ecordonnier 0 Jan 14 11:56 file_no_acl
-rw-rw-r--+ 1 ecordonnier ecordonnier 0 Jan 14 11:56 file_with_acl
+ ../target/debug/ls -l
total 0
-rw-rw-r-- 1 ecordonnier ecordonnier 0 Jan 14 11:56 file_no_acl
-rw-rw-r--+ 1 ecordonnier ecordonnier 0 Jan 14 11:56 file_with_acl

@Ecordonnier
Ecordonnier merged commit fd9157a into uutils:main Jan 14, 2026
128 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ls: When one file has selinux context (or ACL) and another does not, the column alignment in ls -l is off.

3 participants