refactor(dirname): implement pure string manipulation per POSIX#8936
Merged
sylvestre merged 7 commits intoJan 17, 2026
Conversation
Add test_missing_operand to cover error path when dirname called with no arguments (lines 80-82). Add test_multiple_paths_comprehensive to cover loop iteration with mixed edge cases including trailing dot paths, empty strings, and various path types (line 84).
Replace Path::parent() approach with byte-level string operations to avoid path normalization. This ensures dirname behaves as a pure string manipulation tool per POSIX/GNU specifications, correctly handling patterns like foo//., foo/./bar, and preserving /. components in middle of paths. Add comprehensive test coverage for edge cases including multiple slash variations, dot-slash patterns, and component preservation. Addresses issue uutils#8910 with complete POSIX-compliant implementation.
CodSpeed Performance ReportMerging this PR will improve performance by 4.08%Comparing Summary
Performance Changes
Footnotes
|
|
GNU testsuite comparison: |
Contributor
|
@naoNao89 please don't start new pr when others started. Contribute to the other instead :) |
sylvestre
reviewed
Oct 18, 2025
sylvestre
reviewed
Oct 18, 2025
sylvestre
reviewed
Oct 18, 2025
|
GNU testsuite comparison: |
naoNao89
force-pushed
the
test/dirname-additional-coverage
branch
from
63fe1ff to
dc5e0eb
Compare
Contributor
|
why draft ? :) |
naoNao89
force-pushed
the
test/dirname-additional-coverage
branch
from
dc5e0eb to
2c72ad3
Compare
|
GNU testsuite comparison: |
Collaborator
|
@naoNao89 what's the status on this ? It has conflicts |
Contributor
Author
|
resolved |
|
GNU testsuite comparison: |
Contributor
Author
|
Caught an |
sylvestre
reviewed
Dec 30, 2025
| #[test] | ||
| fn test_missing_operand() { | ||
| // Test calling dirname with no arguments - should fail | ||
| // This covers the error path at line 80-82 in dirname.rs |
Contributor
There was a problem hiding this comment.
Suggested change
| // This covers the error path at line 80-82 in dirname.rs |
lines will change
sylvestre
reviewed
Dec 30, 2025
- Remove unnecessary comments from test_dirname.rs - Change dirname_string_manipulation() return type to Cow<'_, [u8]> - Add explicit lifetime annotation to resolve compiler warning - Optimize memory allocation with copy-on-write pattern
Contributor
|
follow up #10294 |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #8924 by rewriting dirname as pure byte-level string operations, avoiding Path::parent() normalization.
Handles all edge cases: foo//., foo///., foo/./, etc. Implementation uses explicit step-by-step logic without unsafe code, making it maintainable and platform-safe.
Added comprehensive tests for slash variations and dot-slash patterns.
Alternative to #8927 - this approach prioritizes code clarity and safety over conciseness. Both fix the same issues, but this avoids unsafe assumptions about OsStr encoding.