-
Notifications
You must be signed in to change notification settings - Fork 18
Company Info Helper #411
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Company Info Helper #411
Conversation
bd46b44
to
47a0c54
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work! I just had some minor comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks good! I just left some very small nitpicks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh one more thing, the file companyinfo.ts
should be renamed to companyInfo.ts
.
fd8a560
to
a9fd5b0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM too!
Summary of Changes
Adds a helper that, given a crunchbase entity id or a crunchbase company page, returns info on the company. Currently returns the following information:
Motivation and Explanation
Works towards #122. Once this is in, we can track companies in our database and start implementing commands.
Related Issues
Resolves #402.
Steps to Reproduce
Call the function through ts-node.
You might not be able to import modules, so you can comment out the imports and replace them with
for testing
Demonstration of Changes
Screen.Recording.2022-11-21.at.9.41.53.PM.mov
Further Information and Comments