Skip to content

Company Info Helper #411

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Nov 25, 2022
Merged

Company Info Helper #411

merged 6 commits into from
Nov 25, 2022

Conversation

victorzheng02
Copy link
Contributor

@victorzheng02 victorzheng02 commented Nov 22, 2022

Summary of Changes

Adds a helper that, given a crunchbase entity id or a crunchbase company page, returns info on the company. Currently returns the following information:

{
  properties: {
    short_description: 'Airbnb is an online community marketplace for people to list, discover, and book accommodations through mobile phones or the internet.',
    identifier: {
      uuid: 'bcb617c3-9e43-d5b0-1d14-82b795f2642f',
      value: 'Airbnb',
      image_id: 'bomkrvppqn1pssoqsxqy',
      permalink: 'airbnb',
      entity_def_id: 'organization'
    }
  }
}

Motivation and Explanation

Works towards #122. Once this is in, we can track companies in our database and start implementing commands.

Related Issues

Resolves #402.

Steps to Reproduce

Call the function through ts-node.
You might not be able to import modules, so you can comment out the imports and replace them with

const fetch = require('node-fetch');
const { isValidUrl } = require('./validateUrl');
const { vars } = require('../config');

for testing

Demonstration of Changes

Screen.Recording.2022-11-21.at.9.41.53.PM.mov

Further Information and Comments

@victorzheng02 victorzheng02 force-pushed the 402-get-company-info-helper branch from bd46b44 to 47a0c54 Compare November 22, 2022 02:44
@victorzheng02 victorzheng02 changed the title done Company Info Helper Nov 22, 2022
Copy link
Contributor

@mcpenguin mcpenguin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! I just had some minor comments.

Copy link
Contributor

@Picowchew Picowchew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good! I just left some very small nitpicks.

Copy link
Contributor

@Picowchew Picowchew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh one more thing, the file companyinfo.ts should be renamed to companyInfo.ts.

@victorzheng02 victorzheng02 force-pushed the 402-get-company-info-helper branch from fd8a560 to a9fd5b0 Compare November 24, 2022 22:09
Copy link
Contributor

@Picowchew Picowchew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@mcpenguin mcpenguin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM too!

@victorzheng02 victorzheng02 merged commit b54d6a3 into main Nov 25, 2022
@victorzheng02 victorzheng02 deleted the 402-get-company-info-helper branch November 25, 2022 05:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement Crunchbase Helper
3 participants