Skip to content

[DAR-6533][External] Do not store duplicate attributes in keyframes #1069

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vvihorev merged 5 commits into from
May 9, 2025
Merged

[DAR-6533][External] Do not store duplicate attributes in keyframes #1069

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
af740a1
Only put attributes in the payload if the attributes have changed
May 7, 2025
f07f959
Update tests/darwin/importer/importer_test.py
vvihorev May 7, 2025
6d5e98e
Ensure frames are sorted, fix None comparison
May 7, 2025
24807d3
Treat all subannotations as a set, include in keyframe if any changed…
May 8, 2025
0c67e33
Remove auto_annotate subannotationn type as never present in the exports
May 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions darwin/datatypes.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -346,6 +346,14 @@ def post_processing(
"hidden_areas": self.hidden_areas,
}

# Only put attributes in the payload if the attributes have changed this frame
last_attributes = None
for idx in sorted(output["frames"]):
attributes = output["frames"][idx].get("attributes")
if attributes is not None and attributes == last_attributes:
output["frames"][idx].pop("attributes")
last_attributes = attributes

return output


Expand Down
5 changes: 3 additions & 2 deletions tests/darwin/importer/importer_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -739,7 +739,7 @@ def test__get_annotation_data_video_annotation_with_attributes_that_become_empty
assert result["frames"][4]["attributes"] == {"attributes": []}


def test__get_annotation_data_video_annotation_does_not_wipe_sub_annotations_when_keyframe_is_true() -> (
def test__get_annotation_data_video_annotation_only_stores_updates_to_sub_annotations_when_keyframe_is_true() -> (
None
):
from darwin.importer.importer import _get_annotation_data
Expand Down Expand Up @@ -785,7 +785,8 @@ def test__get_annotation_data_video_annotation_does_not_wipe_sub_annotations_whe
attributes = {"video_class_id": {"attribute_1": "id_1", "attribute_2": "id_2"}}
result = _get_annotation_data(video_annotation, "video_class_id", attributes)
assert result["frames"][1]["attributes"] == {"attributes": ["id_1", "id_2"]}
assert result["frames"][3]["attributes"] == {"attributes": ["id_1", "id_2"]}
assert 2 not in result["frames"]
assert result["frames"][3].get("attributes") is None


def __expectation_factory(i: int, slot_names: List[str]) -> dt.Annotation:
Expand Down