Fix EVENT_release.ym workflow #1113
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndriiKlymchuk
requested review from
aleksandar-ivic,
saurbhc and
vvihorev
as code owners
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes the EVENT_release.yml workflow by adding missing configuration required to successfully call the JOB_e2e.yml workflow. The changes ensure that E2E tests can run properly during the release process by providing all required secrets and permissions for AWS OIDC authentication.
Key changes:
- Added permissions (id-token: write, contents: read) to the run_e2e job for AWS OIDC authentication
- Added three missing secrets (E2E_VIDEO_AWS_ROLE, E2E_STORAGE_NAME, E2E_STORAGE_REGION) required by the E2E workflow
- Cleaned up trailing whitespace on two lines
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
vvihorev
approved these changes
Dec 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note
Grant OIDC/contents permissions to
run_e2eand pass additional E2E secrets; minor YAML cleanup in release notifications..github/workflows/EVENT_release.yml):id-token: write,contents: readforrun_e2e.E2E_VIDEO_AWS_ROLE,E2E_STORAGE_NAME,E2E_STORAGE_REGION.Written by Cursor Bugbot for commit 1cbed62. This will update automatically on new commits. Configure here.